You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/21 06:13:27 UTC

[GitHub] [maven-plugin-tools] kwin commented on a diff in pull request #117: [4.x] Support for the new maven4 api

kwin commented on code in PR #117:
URL: https://github.com/apache/maven-plugin-tools/pull/117#discussion_r1001404851


##########
maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/MojoAnnotationsScanner.java:
##########
@@ -37,13 +37,21 @@
 {
     String ROLE = MojoAnnotationsScanner.class.getName();
 
+    String V4_API_PLUGIN_PACKAGE = "org.apache.maven.api.plugin";

Review Comment:
   Maybe a bit late but why are the annotations part of maven-api-core? IMHO those are used exclusively at build time (not at run time) by m-plugin-tools only to build the descriptor, so why defining them globally?
   Also why can't the old annotations be extended with just that a boolean flag for v4Api?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org