You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/02/19 09:27:27 UTC
[PR] remove akka from LICENSE-binary [pinot]
pjfanning opened a new pull request, #12443:
URL: https://github.com/apache/pinot/pull/12443
I donloaded the Pinot 1.0.0 binary release and couldn't find any Akka jars or classes. Since Akka is no longer OSS, it is good to try to remove remaining uses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] remove akka from LICENSE-binary [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #12443:
URL: https://github.com/apache/pinot/pull/12443#discussion_r1494684916
##########
LICENSE-binary:
##########
@@ -268,14 +268,7 @@ com.squareup.wire:wire-schema:3.2.2
com.tdunning:t-digest:3.2
com.twitter:chill-java:0.7.6
com.twitter:chill_2.12:0.7.6
-com.typesafe.akka:akka-actor_2.12:2.5.21
-com.typesafe.akka:akka-protobuf_2.12:2.5.21
-com.typesafe.akka:akka-slf4j_2.12:2.5.21
-com.typesafe.akka:akka-stream_2.12:2.5.21
com.typesafe.netty:netty-reactive-streams:2.0.6
-com.typesafe.scala-logging:scala-logging_2.12:3.9.2
Review Comment:
I think this is still in use:
```
mvn dependency:tree |grep typesafe
[INFO] | +- com.typesafe.netty:netty-reactive-streams:jar:2.0.4:compile
[INFO] | +- com.typesafe.netty:netty-reactive-streams:jar:2.0.4:compile
[INFO] | +- com.typesafe.scala-logging:scala-logging_2.12:jar:3.9.2:compile
[INFO] | +- com.typesafe.netty:netty-reactive-streams:jar:2.0.6:compile
[INFO] | | \- com.typesafe.scala-logging:scala-logging_2.12:jar:3.9.2:runtime
[INFO] | | +- com.typesafe.netty:netty-reactive-streams:jar:2.0.4:compile
[INFO] | | \- com.typesafe.scala-logging:scala-logging_2.12:jar:3.9.2:runtime
[INFO] | | +- com.typesafe.netty:netty-reactive-streams:jar:2.0.4:compile
[INFO] | | \- com.typesafe.scala-logging:scala-logging_2.12:jar:3.9.2:runtime
[INFO] | | \- com.typesafe.scala-logging:scala-logging_2.12:jar:3.9.2:runtime
[INFO] | | +- com.typesafe.netty:netty-reactive-streams:jar:2.0.4:compile
[INFO] | | +- com.typesafe.netty:netty-reactive-streams:jar:2.0.4:compile
[INFO] | +- com.typesafe.netty:netty-reactive-streams:jar:2.0.4:test
[INFO] | | \- com.typesafe.scala-logging:scala-logging_2.12:jar:3.9.2:test
[INFO] | | | \- com.typesafe.scala-logging:scala-logging_2.12:jar:3.9.2:runtime
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] remove akka from LICENSE-binary [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #12443:
URL: https://github.com/apache/pinot/pull/12443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] remove akka from LICENSE-binary [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on PR #12443:
URL: https://github.com/apache/pinot/pull/12443#issuecomment-1953887878
Thanks for updating this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] remove akka from LICENSE-binary [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #12443:
URL: https://github.com/apache/pinot/pull/12443#issuecomment-1952111887
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12443?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`1d490c1`)](https://app.codecov.io/gh/apache/pinot/commit/1d490c1ac3268103a16d77ddfa70f8f8602f9e96?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 61.77% compared to head [(`f66fdc2`)](https://app.codecov.io/gh/apache/pinot/pull/12443?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 27.73%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #12443 +/- ##
=============================================
- Coverage 61.77% 27.73% -34.05%
Complexity 207 207
=============================================
Files 2436 2436
Lines 133130 133128 -2
Branches 20623 20623
=============================================
- Hits 82241 36921 -45320
- Misses 44850 93400 +48550
+ Partials 6039 2807 -3232
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/12443/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/12443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/12443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `<0.01% <ø> (ø)` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/12443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `<0.01% <ø> (ø)` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/12443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/12443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/12443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.73% <ø> (-33.93%)` | :arrow_down: |
| [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/12443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.73% <ø> (-34.00%)` | :arrow_down: |
| [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/12443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `<0.01% <ø> (-61.62%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/12443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.73% <ø> (-34.05%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/12443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.72% <ø> (-34.05%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/12443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/12443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.72% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/12443?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] remove akka from LICENSE-binary [pinot]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #12443:
URL: https://github.com/apache/pinot/pull/12443#discussion_r1494968616
##########
LICENSE-binary:
##########
@@ -268,14 +268,7 @@ com.squareup.wire:wire-schema:3.2.2
com.tdunning:t-digest:3.2
com.twitter:chill-java:0.7.6
com.twitter:chill_2.12:0.7.6
-com.typesafe.akka:akka-actor_2.12:2.5.21
-com.typesafe.akka:akka-protobuf_2.12:2.5.21
-com.typesafe.akka:akka-slf4j_2.12:2.5.21
-com.typesafe.akka:akka-stream_2.12:2.5.21
com.typesafe.netty:netty-reactive-streams:2.0.6
-com.typesafe.scala-logging:scala-logging_2.12:3.9.2
Review Comment:
thanks - added back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org