You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2021/09/20 21:57:00 UTC

[jira] [Commented] (CASSANDRA-16981) Respect com.sun.management.jxmremote.host

    [ https://issues.apache.org/jira/browse/CASSANDRA-16981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417823#comment-17417823 ] 

Ekaterina Dimitrova commented on CASSANDRA-16981:
-------------------------------------------------

This issue was patched originally by [~brandon.williams].

I ported the fix to cassandra-3.11 [here|https://github.com/ekaterinadimitrova2/cassandra/commit/14964ce868846f8a13dede060e5d2dca30211ee2] but I can't run the new unit tests in CI because we don't have _lsof_.

CircleCI [fails|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1119/workflows/804340ae-db4b-4bcf-954a-4ef8b5f58332/jobs/6604/tests#failed-test-0] with the below error:

 
{code:java}
java.lang.RuntimeException: java.io.IOException: Cannot run program "lsof": error=2, No such file or directory
at org.apache.cassandra.utils.JMXServerUtilsTest.validateBound(JMXServerUtilsTest.java:319) at org.apache.cassandra.utils.JMXServerUtilsTest.sslJmxServerBindToAny(JMXServerUtilsTest.java:198) Caused by: java.io.IOException: Cannot run program "lsof": error=2, No such file or directory at java.lang.ProcessBuilder.start(ProcessBuilder.java:1048) at org.apache.cassandra.utils.JMXServerUtilsTest.validateBound(JMXServerUtilsTest.java:309) Caused by: java.io.IOException: error=2, No such file or directory at java.lang.UNIXProcess.forkAndExec(Native Method) at java.lang.UNIXProcess.<init>(UNIXProcess.java:247) at java.lang.ProcessImpl.start(ProcessImpl.java:134) at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)


{code}
 

Ping [~mck] if you can help me with that part (_lsof_) when you have time. I believe we need to make some changes to the image? 

I will propagate to all branches when we are sure what we want here and what is feasible around the testing. 

> Respect com.sun.management.jxmremote.host 
> ------------------------------------------
>
>                 Key: CASSANDRA-16981
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16981
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Legacy/Core
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 3.11.x, 4.0.x, 4.x
>
>
> It seems we don't respect com.sun.management.jxmremote.host in [createJMXServer()|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/utils/JMXServerUtils.java#L64]
>  The flow should be - when_ local _is true, we only bind localhost, otherwise we bind everything, unless com.sun.management.jmxremote.host is set, then we use that.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org