You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/07 22:45:50 UTC
[GitHub] [airflow] potiuk opened a new pull request, #24307: Update release notes for RC2 release of Providers for May 2022
potiuk opened a new pull request, #24307:
URL: https://github.com/apache/airflow/pull/24307
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24307: Update release notes for RC2 release of Providers for May 2022
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24307:
URL: https://github.com/apache/airflow/pull/24307#issuecomment-1150334609
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #24307: Update release notes for RC2 release of Providers for May 2022
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #24307:
URL: https://github.com/apache/airflow/pull/24307#discussion_r892875860
##########
docs/apache-airflow-providers-amazon/example-dags.rst:
##########
@@ -20,4 +20,4 @@ Example DAGs
You can learn how to use Amazon AWS integrations by analyzing the source code of the example DAGs:
-* `Amazon AWS <https://github.com/apache/airflow/tree/main/airflow/providers/amazon/aws/example_dags>`__
+* `Amazon AWS <https://github.com/apache/airflow/tree/providers-amazon/4.0.0/tests/system/providers/amazon/aws>`__
Review Comment:
Should be fine now :) . We should have legacy links now for both google and amazon (those are the only ones which are in-progress.. And the legacy link will disappear when completed.
While doing so, I also fixed an inconsistency in google examples - the "cloud" examples weren't in "cloud" subfolder in tests/systems/. This is now fixed and verified by pre-commit too, so it was worth the effort :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #24307: Update release notes for RC2 release of Providers for May 2022
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #24307:
URL: https://github.com/apache/airflow/pull/24307#discussion_r892811074
##########
docs/apache-airflow-providers-amazon/example-dags.rst:
##########
@@ -20,4 +20,4 @@ Example DAGs
You can learn how to use Amazon AWS integrations by analyzing the source code of the example DAGs:
-* `Amazon AWS <https://github.com/apache/airflow/tree/main/airflow/providers/amazon/aws/example_dags>`__
+* `Amazon AWS <https://github.com/apache/airflow/tree/providers-amazon/4.0.0/tests/system/providers/amazon/aws>`__
Review Comment:
Well it's wrong both ways in fact ... But I could modify it slightly to add BOTH links in this case :) Hold my beer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24307: Update release notes for RC2 release of Providers for May 2022
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24307:
URL: https://github.com/apache/airflow/pull/24307#issuecomment-1150242313
Hey @josh-fell - this one contains pre-commit that fixes #24331 in the new provider's release :). I will use the code - slightly modified - to also fix historical pages later, when we see that one working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24307: Update release notes for RC2 release of Providers for May 2022
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24307:
URL: https://github.com/apache/airflow/pull/24307#issuecomment-1150030896
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24307: Update release notes for RC2 release of Providers for May 2022
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24307:
URL: https://github.com/apache/airflow/pull/24307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24307: Update release notes for RC2 release of Providers for May 2022
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24307:
URL: https://github.com/apache/airflow/pull/24307#issuecomment-1150064229
I tihnk this is the last one: https://github.com/apache/airflow/pull/24330 I will rebase this one and update and Can release RC2 after that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on a diff in pull request #24307: Update release notes for RC2 release of Providers for May 2022
Posted by GitBox <gi...@apache.org>.
josh-fell commented on code in PR #24307:
URL: https://github.com/apache/airflow/pull/24307#discussion_r892798520
##########
docs/apache-airflow-providers-amazon/example-dags.rst:
##########
@@ -20,4 +20,4 @@ Example DAGs
You can learn how to use Amazon AWS integrations by analyzing the source code of the example DAGs:
-* `Amazon AWS <https://github.com/apache/airflow/tree/main/airflow/providers/amazon/aws/example_dags>`__
+* `Amazon AWS <https://github.com/apache/airflow/tree/providers-amazon/4.0.0/tests/system/providers/amazon/aws>`__
Review Comment:
For the providers that are still in progress for their transition from example DAGs to system tests (e.g. Amazon, Google), should we default to pointing to system tests even if there are still example DAGs in the original directory (and in the case of Amazon, the vast majority haven't been migrated)? Maybe we check if the example DAG path exists first in the pre-commit check instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on a diff in pull request #24307: Update release notes for RC2 release of Providers for May 2022
Posted by GitBox <gi...@apache.org>.
josh-fell commented on code in PR #24307:
URL: https://github.com/apache/airflow/pull/24307#discussion_r892880866
##########
docs/apache-airflow-providers-google/example-dags.rst:
##########
@@ -20,9 +20,10 @@ Example DAGs
You can learn how to use Google integrations by analyzing the source code of the example DAGs:
-* `Google Ads <https://github.com/apache/airflow/tree/main/airflow/providers/google/ads/example_dags>`__
-* `Google Cloud <https://github.com/apache/airflow/tree/main/airflow/providers/google/cloud/example_dags>`__
-* `Google Firebase <https://github.com/apache/airflow/tree/main/airflow/providers/google/firebase/example_dags>`__
-* `Google Marketing Platform <https://github.com/apache/airflow/tree/main/airflow/providers/google/marketing_platform/example_dags>`__
-* `Google Workplace <https://github.com/apache/airflow/tree/main/airflow/providers/google/suite/example_dags>`__ (formerly Google Suite)
-* `Google LevelDB <https://github.com/apache/airflow/tree/main/airflow/providers/google/leveldb/example_dags>`__
+* `Google Ads <https://github.com/apache/airflow/tree/providers-google/8.0.0/airflow/providers/google/ads/example_dags>`__
+* `Google Cloud <https://github.com/apache/airflow/tree/providers-google/8.0.0/airflow/providers/google/cloud/example_dags>`__
+* `Google Cloud (legacy) <https://github.com/apache/airflow/tree/providers-google/8.0.0/tests/system/providers/google/cloud>`__
Review Comment:
```suggestion
* `Google Cloud (legacy examples) <https://github.com/apache/airflow/tree/providers-google/8.0.0/airflow/providers/google/cloud/example_dags>`__
* `Google Cloud <https://github.com/apache/airflow/tree/providers-google/8.0.0/tests/system/providers/google/cloud>`__
```
To be consistent with Amazon with `example_dags/` being legacy. I don't feel strongly on "(legacy)" vs "(legacy examples)" verbiage though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org