You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/02/01 21:21:08 UTC

[GitHub] [daffodil] scala-steward opened a new pull request #745: Update Saxon-HE to 11.1

scala-steward opened a new pull request #745:
URL: https://github.com/apache/daffodil/pull/745


   Updates net.sf.saxon:Saxon-HE from 10.6 to 11.1.
   
   
   I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
   
   If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
   
   Configure Scala Steward for your repository with a [`.scala-steward.conf`](https://github.com/scala-steward-org/scala-steward/blob/0acb15209c04af84f3c2afcfec7802cdffcec4f3/docs/repo-specific-configuration.md) file.
   
   Have a fantastic day writing Scala!
   
   <details>
   <summary>Ignore future updates</summary>
   
   Add this to your `.scala-steward.conf` file to ignore future updates of this dependency:
   ```
   updates.ignore = [ { groupId = "net.sf.saxon", artifactId = "Saxon-HE" } ]
   ```
   </details>
   
   labels: library-update, commit-count:1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] mbeckerle commented on pull request #745: Update Saxon-HE to 11.1

Posted by GitBox <gi...@apache.org>.
mbeckerle commented on pull request #745:
URL: https://github.com/apache/daffodil/pull/745#issuecomment-1027927377


   What do we use saxon for again? If it is not being configured to use our resolver instead of its own, then it can't be to process DFDL schemas nor TDML because our schemaLocations depend on our classpath-enabled xml resolver. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] mbeckerle commented on pull request #745: Update Saxon-HE to 11.1

Posted by GitBox <gi...@apache.org>.
mbeckerle commented on pull request #745:
URL: https://github.com/apache/daffodil/pull/745#issuecomment-1028351682


   So assuming schematron has some notion of include/import, that won't work from jars on classpath because this is not using our resolver. It is ok for that to be a bug. We should test it I guess. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] stevedlawrence commented on pull request #745: Update Saxon-HE to 11.1

Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #745:
URL: https://github.com/apache/daffodil/pull/745#issuecomment-1028183796


   Makes sense. I think this is good to squash and merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] tuxji merged pull request #745: Update Saxon-HE to 11.1

Posted by GitBox <gi...@apache.org>.
tuxji merged pull request #745:
URL: https://github.com/apache/daffodil/pull/745


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] stevedlawrence commented on pull request #745: Update Saxon-HE to 11.1

Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #745:
URL: https://github.com/apache/daffodil/pull/745#issuecomment-1027933417


   It looks like Saxon was added for schematron validation in commit d65af5b22a742a09594f277e8154dd4078cf3459. So I guess the rest of Daffodil won't use this new xml resolver and shouldn't have any issues. And I guess since it uses schematron files, it doesn't need to know about our resolution logic?
   
   In fact, looking at our schematron implementation it looks like it has added custom logic to allow resolving to files on the classpath:
   
   https://github.com/apache/daffodil/blob/main/daffodil-schematron/src/main/scala/org/apache/daffodil/validation/schematron/ClassPathUriResolver.scala
   
   I think schematron and saxon are just completely separate from the rest of Daffodil, and so this new xmlresolver should be fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] tuxji commented on pull request #745: Update Saxon-HE to 11.1

Posted by GitBox <gi...@apache.org>.
tuxji commented on pull request #745:
URL: https://github.com/apache/daffodil/pull/745#issuecomment-1028180210


   Yes, Saxon is used only by the Daffodil Schematron validator.  Schematron validation requires XSLT stylesheet processing and Xerces is an XML processor only, not an XSLT processor, so @jw3 had to pick either Saxon or Apache Xalan and Xalan has had only one new [release](https://xalan.apache.org/) since 2011.  The Apache Commons XML resolver has had no new [release](https://xerces.apache.org/xml-commons/components/resolver/resolver-release-notes.html) since 2006 itself, while the XML Resolver project has had 46 [releases](https://github.com/xmlresolver/xmlresolver/releases) since 2015 and comes with all the standard DTDs, schemas etc. [packaged](https://github.com/xmlresolver/xmlresolverdata) in a data jar.  Just saying :-).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org