You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:14:27 UTC
[GitHub] [james-project] Arsnael commented on a change in pull request #490: JAMES-3597 Exclude deleted messages from JMAP Email/query
Arsnael commented on a change in pull request #490:
URL: https://github.com/apache/james-project/pull/490#discussion_r649793740
##########
File path: server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/EmailQueryMethodContract.scala
##########
@@ -206,6 +206,63 @@ trait EmailQueryMethodContract {
}
}
+ @Disabled("JAMES-3597 Deleted messages are exposed over JMAP")
+ @Test
+ def messagesMarkedAsDeeltedShouldNotBeExposedOverJMAP(server: GuiceJamesServer): Unit = {
Review comment:
```suggestion
def messagesMarkedAsDeletedShouldNotBeExposedOverJMAP(server: GuiceJamesServer): Unit = {
```
##########
File path: server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/EmailQueryMethodContract.scala
##########
@@ -206,6 +206,63 @@ trait EmailQueryMethodContract {
}
}
+ @Disabled("JAMES-3597 Deleted messages are exposed over JMAP")
Review comment:
Shouldn't you remove this `Disabled` on your last commit fixing the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org