You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/01/11 13:36:28 UTC
[GitHub] [incubator-echarts] Zaynex opened a new pull request #12022:
fix(themeRiver): use layer key map rather then largestLayer #11948
Zaynex opened a new pull request #12022: fix(themeRiver): use layer key map rather then largestLayer #11948
URL: https://github.com/apache/incubator-echarts/pull/12022
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Keep the number of layer keys in each layer consistent.
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
### Fixed issues
Fixed issue #11948
<!--
- #xxxx: ...
-->
## Details
### Before: What was the problem?
Use largest layer array is not enough. Because each layer may have a different key, each layer array is inconsistent after call fixdata.
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
### After: How is it fixed in this PR?
Save all the layer keys, and if any layer data lack one of keys, add default data(lack key: value) to layer .
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [x] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] 100pah merged pull request #12022: fix(themeRiver): use layer key map rather then largestLayer #11948
Posted by GitBox <gi...@apache.org>.
100pah merged pull request #12022:
URL: https://github.com/apache/incubator-echarts/pull/12022
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12022: fix(themeRiver): use layer key map rather then largestLayer #11948
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12022:
URL: https://github.com/apache/incubator-echarts/pull/12022#issuecomment-669054211
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org