You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/02/11 02:14:36 UTC
Review Request 30859: Remove thrift checksum verification script and
resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30859/
-----------------------------------------------------------
Review request for Aurora and Maxim Khutornenko.
Repository: aurora
Description
-------
This was a failed idea, and turns out to be unwired now anyhow. We've moved towards managing this by convention and documentation instead, which is necessary anyway.
Diffs
-----
src/test/resources/org/apache/aurora/gen/api.thrift.md5 e2bea71d6491072d12c3264faed660f065892b40
src/test/resources/org/apache/aurora/gen/internal_rpc.thrift.md5 875f2eb566017e959b1bedf837fbbb8ebbddeaf0
src/test/resources/org/apache/aurora/gen/storage.thrift.md5 6da2c2cf066f725a3ef6d4b27d35eb755d374da4
src/test/resources/org/apache/aurora/gen/storage_local.thrift.md5 335569bbdb9079abe35d06fda2667115310559f4
src/test/resources/org/apache/aurora/gen/test.thrift.md5 be750e010f3230c6ccd67bbb548f9aadb590498e
src/test/resources/org/apache/thermos/thermos_internal.thrift.md5 ba65ed2996ca360ff80c53018e51617f91d494f0
src/test/sh/org/apache/aurora/verify_thrift_checksum.sh 8496bd00804af5a94ecc19c6cf2caacae2ff4c8e
Diff: https://reviews.apache.org/r/30859/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 30859: Remove thrift checksum verification script
and resources.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30859/#review71898
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 11, 2015, 1:14 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30859/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2015, 1:14 a.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This was a failed idea, and turns out to be unwired now anyhow. We've moved towards managing this by convention and documentation instead, which is necessary anyway.
>
>
> Diffs
> -----
>
> src/test/resources/org/apache/aurora/gen/api.thrift.md5 e2bea71d6491072d12c3264faed660f065892b40
> src/test/resources/org/apache/aurora/gen/internal_rpc.thrift.md5 875f2eb566017e959b1bedf837fbbb8ebbddeaf0
> src/test/resources/org/apache/aurora/gen/storage.thrift.md5 6da2c2cf066f725a3ef6d4b27d35eb755d374da4
> src/test/resources/org/apache/aurora/gen/storage_local.thrift.md5 335569bbdb9079abe35d06fda2667115310559f4
> src/test/resources/org/apache/aurora/gen/test.thrift.md5 be750e010f3230c6ccd67bbb548f9aadb590498e
> src/test/resources/org/apache/thermos/thermos_internal.thrift.md5 ba65ed2996ca360ff80c53018e51617f91d494f0
> src/test/sh/org/apache/aurora/verify_thrift_checksum.sh 8496bd00804af5a94ecc19c6cf2caacae2ff4c8e
>
> Diff: https://reviews.apache.org/r/30859/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 30859: Remove thrift checksum verification script
and resources.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30859/#review71912
-----------------------------------------------------------
Ship it!
Master (64fa0ca) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 11, 2015, 1:14 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30859/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2015, 1:14 a.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This was a failed idea, and turns out to be unwired now anyhow. We've moved towards managing this by convention and documentation instead, which is necessary anyway.
>
>
> Diffs
> -----
>
> src/test/resources/org/apache/aurora/gen/api.thrift.md5 e2bea71d6491072d12c3264faed660f065892b40
> src/test/resources/org/apache/aurora/gen/internal_rpc.thrift.md5 875f2eb566017e959b1bedf837fbbb8ebbddeaf0
> src/test/resources/org/apache/aurora/gen/storage.thrift.md5 6da2c2cf066f725a3ef6d4b27d35eb755d374da4
> src/test/resources/org/apache/aurora/gen/storage_local.thrift.md5 335569bbdb9079abe35d06fda2667115310559f4
> src/test/resources/org/apache/aurora/gen/test.thrift.md5 be750e010f3230c6ccd67bbb548f9aadb590498e
> src/test/resources/org/apache/thermos/thermos_internal.thrift.md5 ba65ed2996ca360ff80c53018e51617f91d494f0
> src/test/sh/org/apache/aurora/verify_thrift_checksum.sh 8496bd00804af5a94ecc19c6cf2caacae2ff4c8e
>
> Diff: https://reviews.apache.org/r/30859/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>