You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Akash Gupta <ak...@hotmail.com> on 2018/05/04 17:16:20 UTC
Review Request 66953: Windows: Fixed dup to properly copy the
overlapped WindowsFD.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66953/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich, Joseph Wu, and Radhika Jandhyala.
Bugs: MESOS-8674
https://issues.apache.org/jira/browse/MESOS-8674
Repository: mesos
Description
-------
After the previous commit,`os::dup` was not copying the overlapped
field, so it has been updated to copy it.
Diffs
-----
3rdparty/stout/include/stout/os/windows/dup.hpp af98054f1bd9c8e55c52b246fda8734e3ca96e21
Diff: https://reviews.apache.org/r/66953/diff/1/
Testing
-------
Thanks,
Akash Gupta
Re: Review Request 66953: Windows: Fixed dup to properly copy the
overlapped WindowsFD.
Posted by Radhika Jandhyala via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66953/#review202505
-----------------------------------------------------------
Ship it!
Ship It!
- Radhika Jandhyala
On May 4, 2018, 5:16 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66953/
> -----------------------------------------------------------
>
> (Updated May 4, 2018, 5:16 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich, Joseph Wu, and Radhika Jandhyala.
>
>
> Bugs: MESOS-8670
> https://issues.apache.org/jira/browse/MESOS-8670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After the previous commit,`os::dup` was not copying the overlapped
> field, so it has been updated to copy it.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/dup.hpp af98054f1bd9c8e55c52b246fda8734e3ca96e21
>
>
> Diff: https://reviews.apache.org/r/66953/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 66953: Windows: Fixed dup to properly copy the
overlapped WindowsFD.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66953/#review202570
-----------------------------------------------------------
This could/should be squashed into the prior commit. Reasoning: prior commit is broken without it, it's logically the same change, and it's all still in stout.
- Andrew Schwartzmeyer
On May 4, 2018, 10:16 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66953/
> -----------------------------------------------------------
>
> (Updated May 4, 2018, 10:16 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich, Joseph Wu, and Radhika Jandhyala.
>
>
> Bugs: MESOS-8670
> https://issues.apache.org/jira/browse/MESOS-8670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After the previous commit,`os::dup` was not copying the overlapped
> field, so it has been updated to copy it.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/dup.hpp af98054f1bd9c8e55c52b246fda8734e3ca96e21
>
>
> Diff: https://reviews.apache.org/r/66953/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 66953: Windows: Fixed dup to properly copy the
overlapped WindowsFD.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66953/#review202577
-----------------------------------------------------------
3rdparty/stout/include/stout/os/windows/dup.hpp
Line 43 (original), 43 (patched)
<https://reviews.apache.org/r/66953/#comment284404>
This could/should be squashed into the prior commit. Reasoning: prior commit is broken without it, it's logically the same change, and it's all still in stout.
(Moved to issue so it... opens an issue.)
- Andrew Schwartzmeyer
On May 4, 2018, 10:16 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66953/
> -----------------------------------------------------------
>
> (Updated May 4, 2018, 10:16 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich, Joseph Wu, and Radhika Jandhyala.
>
>
> Bugs: MESOS-8670
> https://issues.apache.org/jira/browse/MESOS-8670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After the previous commit,`os::dup` was not copying the overlapped
> field, so it has been updated to copy it.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/dup.hpp af98054f1bd9c8e55c52b246fda8734e3ca96e21
>
>
> Diff: https://reviews.apache.org/r/66953/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>