[GitHub] [kafka] mumrah commented on a diff in pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

["mumrah (via GitHub)" <gi...@apache.org>]

mumrah commented on code in PR #13183:
URL: https://github.com/apache/kafka/pull/13183#discussion_r1094614887


##########
server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java:
##########
@@ -250,7 +250,7 @@ private void handleEvents() throws InterruptedException {
                             continue;
                         } else if (shuttingDown) {
                             remove(eventContext);
-                            toDeliver = new TimeoutException();
+                            toDeliver = new QueueClosingException();

Review Comment:
   I thought about `RejectedExecutionException`, but wasn't sure if we relied on the `TimeoutException` type somewhere, so I made a subclass of that. If you think it's fine, we'll go with `RejectedExecutionException`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org