You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/02/05 06:29:22 UTC

[GitHub] [flink] zhuzhurk commented on a change in pull request #14862: [FLINK-21273][coordination] Remove unused ExecutionVertexSchedulingRe…

zhuzhurk commented on a change in pull request #14862:
URL: https://github.com/apache/flink/pull/14862#discussion_r570744967



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SlotSharingExecutionSlotAllocator.java
##########
@@ -115,15 +115,11 @@
      *       returns the results.
      * </ol>
      *
-     * @param executionVertexSchedulingRequirements the requirements for scheduling the executions.
+     * @param executionVertexIds the requirements for scheduling the executions.

Review comment:
       the comment is outdated

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/ExecutionSlotAllocator.java
##########
@@ -29,10 +29,10 @@
     /**
      * Allocate slots for the given executions.
      *
-     * @param executionVertexSchedulingRequirements The requirements for scheduling the executions.
+     * @param executionVertexIds The requirements for scheduling the executions.

Review comment:
       "The requirements for scheduling the executions" -> "Execution vertices to allocate slots for"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org