[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1745: change: remove ID of consumer

[GitBox <gi...@apache.org>]

starsz commented on a change in pull request #1745:
URL: https://github.com/apache/apisix-dashboard/pull/1745#discussion_r611195308



##########
File path: api/test/e2e/route_with_plugin_jwt_test.go
##########
@@ -100,6 +101,12 @@ func TestRoute_With_Jwt_Plugin(t *testing.T) {
 	assert.Equal(t, http.StatusOK, status)
 	jwtToken := string(body)
 
+
+	// sleep for process log
+	time.Sleep(1500 * time.Millisecond)
+	logContent := ReadAPISIXErrorLog(t)
+	fmt.Println("logContent:", logContent)

Review comment:
       This is debugging info?

##########
File path: api/internal/handler/consumer/consumer_test.go
##########
@@ -391,10 +369,12 @@ func TestHandler_Update(t *testing.T) {
 			mStore.On("Update", mock.Anything, mock.Anything, mock.Anything).Run(func(args mock.Arguments) {
 				methodCalled = true
 				assert.Equal(t, tc.giveCtx, args.Get(0))
-				assert.Equal(t, tc.wantInput, args.Get(1))
 				assert.True(t, args.Bool(2))
 			}).Return(tc.giveRet, tc.giveErr)
 
+			mStore.On("Get", mock.Anything).Run(func(args mock.Arguments) {
+			}).Return(nil, nil)

Review comment:
       We should test if the Get returns a consumer.

##########
File path: api/test/docker/apisix_config.yaml
##########
@@ -22,7 +22,7 @@ etcd:
     - "http://172.16.238.10:2379"
     - "http://172.16.238.11:2379"
     - "http://172.16.238.12:2379"
-  resync_delay: 0.1  # sync data from etcd quickly for e2e test
+  resync_delay: 1  # sync data from etcd quickly for e2e test

Review comment:
       Do we need to modify this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org