[GitHub] [hbase] nyl3532016 commented on a change in pull request #2437: HBASE-25053 WAL replay should ignore 0-length files

[GitBox <gi...@apache.org>]

nyl3532016 commented on a change in pull request #2437:
URL: https://github.com/apache/hbase/pull/2437#discussion_r495768332



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -6423,7 +6427,11 @@ protected void restoreEdit(HStore s, Cell cell, MemStoreSizing memstoreAccountin
    * @throws IOException
    */
   private static boolean isZeroLengthThenDelete(final FileSystem fs, final FileStatus stat,
-      final Path p) throws IOException {
+      final Path p, Configuration conf) throws IOException {
+    if (stat.getLen() > 0) {
+      return false;
+    }
+    RecoverLeaseFSUtils.recoverFileLease(fs, p, conf);

Review comment:
       https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java#L255
   I think we can make sure we finish rename and recover lease




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org