[GitHub] [pulsar] lhotari commented on a diff in pull request #16996: [fix][broker] Fix memory leak if entry exists in cache

[GitBox <gi...@apache.org>]

lhotari commented on code in PR #16996:
URL: https://github.com/apache/pulsar/pull/16996#discussion_r941065016


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java:
##########
@@ -211,13 +211,8 @@ public void safeRun() {
         if (ml.hasActiveCursors()) {
             // Avoid caching entries if no cursor has been created
             EntryImpl entry = EntryImpl.create(ledger.getId(), entryId, data);
-            // EntryCache.insert: duplicates entry by allocating new entry and data. so, recycle entry after calling
-            // insert

Review Comment:
   these comments on lines 214 and 215 are still valid and shouldn't be removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org