[GitHub] [james-project] Arsnael commented on a diff in pull request #1540: JAMES-3905 LDAP should allow per user base DN

["Arsnael (via GitHub)" <gi...@apache.org>]

Arsnael commented on code in PR #1540:
URL: https://github.com/apache/james-project/pull/1540#discussion_r1177296299


##########
server/data/data-ldap/src/test/resources/ldif-files/populate.ldif:
##########
@@ -14,3 +18,12 @@ sn: james-user
 mail: james-user@james.org
 userPassword: secret
 description: James user
+
+dn: uid=bob, ou=whatever, dc=james,dc=org

Review Comment:
   My knowledge of ldap is limited but shouldn't it be more logical to have:
   
   ```suggestion
   dn: uid=bob, ou=whatever, dc=extra,dc=org
   ```
   instead?



##########
server/data/data-ldap/src/test/resources/ldif-files/populate.ldif:
##########
@@ -6,6 +6,10 @@ dn: ou=empty, dc=james,dc=org
 ou: empty
 objectClass: organizationalUnit
 
+dn: ou=whatever, dc=james,dc=org

Review Comment:
   idem here? dc=james => dc=extra, if domain name is extra.org?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org