You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Doug Cutting (JIRA)" <ji...@apache.org> on 2007/03/26 22:30:32 UTC
[jira] Commented: (HADOOP-958) Building Hadoop results in a lot of
warnings
[ https://issues.apache.org/jira/browse/HADOOP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484219 ]
Doug Cutting commented on HADOOP-958:
-------------------------------------
> if a series of patches like this one are committed, is it OK to do them all under one Jira issue?
As long as they all make it in a single release, this is fine with me. In theory we can even map issues to multiple releases, each in which they're partially fixed, but that could get confusing and I find it simpler when the set of issues in subsequent releases are disjoint.
> Building Hadoop results in a lot of warnings
> --------------------------------------------
>
> Key: HADOOP-958
> URL: https://issues.apache.org/jira/browse/HADOOP-958
> Project: Hadoop
> Issue Type: Improvement
> Reporter: eric baldeschwieler
> Attachments: example-warnings.patch, fs-unchecked.patch
>
>
> We are getting hundreds of warnings right now. Most of these are a result of our transition to 1.5 and deprecated uses of generics. We should still fix these, since producing lots of warnings:
> A) Leads to the perception that our code is of low quality
> B) Can mask warnings that come from real issues.
> ---
> I suggest we do two things
> 1) Submit a patch or set of patches to clean this up
> 2) Change our patch tester to validate that the number of warnings per build did not go up with this patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (HADOOP-958) Building Hadoop results in a lot
of warnings
Posted by Doug Cutting <cu...@apache.org>.
Nigel Daley wrote:
> Should we try to do all code format changes in a series of contiguous
> patches?
This is more than a format change, but I see what you mean.
> This should minimize the amount of pain while diff'ing source
> files across revisions. Also, should these format changes be the last
> patches applied before a release or the first patches applied after a
> release?
I think for this issue, which is not completely automatic, my hunch is
to pursue it piecemeal. Also, as we more actively maintain multiple
branches, the notions of just-before or just-after a release don't make
quite as much sense, since these changes will affect merging. So doing
it all at once in one release will make all merging harder for that
release, while spreading it over multiple releases will spread the merge
pain out. That said, if someone has a patch ready that updates the
whole tree and that applies cleanly to trunk at a time when the patch
queue is empty, then I'd vote to just commit it and deal with the
consequences. However the patch queue hasn't been empty for a while...
Doug
Re: [jira] Commented: (HADOOP-958) Building Hadoop results in a lot of warnings
Posted by Nigel Daley <nd...@yahoo-inc.com>.
>> if a series of patches like this one are committed, is it OK to do
>> them all under one Jira issue?
>
> As long as they all make it in a single release, this is fine with
> me. In theory we can even map issues to multiple releases, each in
> which they're partially fixed, but that could get confusing and I
> find it simpler when the set of issues in subsequent releases are
> disjoint.
Should we try to do all code format changes in a series of contiguous
patches? This should minimize the amount of pain while diff'ing
source files across revisions. Also, should these format changes be
the last patches applied before a release or the first patches
applied after a release?
On Mar 26, 2007, at 1:30 PM, Doug Cutting (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/HADOOP-958?
> page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel#action_12484219 ]
>
> Doug Cutting commented on HADOOP-958:
> -------------------------------------
>
>> if a series of patches like this one are committed, is it OK to do
>> them all under one Jira issue?
>
> As long as they all make it in a single release, this is fine with
> me. In theory we can even map issues to multiple releases, each in
> which they're partially fixed, but that could get confusing and I
> find it simpler when the set of issues in subsequent releases are
> disjoint.
>
>> Building Hadoop results in a lot of warnings
>> --------------------------------------------
>>
>> Key: HADOOP-958
>> URL: https://issues.apache.org/jira/browse/HADOOP-958
>> Project: Hadoop
>> Issue Type: Improvement
>> Reporter: eric baldeschwieler
>> Attachments: example-warnings.patch, fs-unchecked.patch
>>
>>
>> We are getting hundreds of warnings right now. Most of these are
>> a result of our transition to 1.5 and deprecated uses of
>> generics. We should still fix these, since producing lots of
>> warnings:
>> A) Leads to the perception that our code is of low quality
>> B) Can mask warnings that come from real issues.
>> ---
>> I suggest we do two things
>> 1) Submit a patch or set of patches to clean this up
>> 2) Change our patch tester to validate that the number of warnings
>> per build did not go up with this patch
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>