You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2020/12/06 16:53:14 UTC

svn commit: r1884158 - in /poi/trunk/src: java/org/apache/poi/common/usermodel/ java/org/apache/poi/hssf/usermodel/ ooxml/java/org/apache/poi/xssf/usermodel/

Author: fanningpj
Date: Sun Dec  6 16:53:14 2020
New Revision: 1884158

URL: http://svn.apache.org/viewvc?rev=1884158&view=rev
Log:
remove some deprecated code

Modified:
    poi/trunk/src/java/org/apache/poi/common/usermodel/Hyperlink.java
    poi/trunk/src/java/org/apache/poi/common/usermodel/HyperlinkType.java
    poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFHyperlink.java
    poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFHyperlink.java

Modified: poi/trunk/src/java/org/apache/poi/common/usermodel/Hyperlink.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/common/usermodel/Hyperlink.java?rev=1884158&r1=1884157&r2=1884158&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/common/usermodel/Hyperlink.java (original)
+++ poi/trunk/src/java/org/apache/poi/common/usermodel/Hyperlink.java Sun Dec  6 16:53:14 2020
@@ -55,7 +55,6 @@ public interface Hyperlink {
      * Return the type of this hyperlink
      *
      * @return the type of this hyperlink
-     * @see HyperlinkType#forInt(int)
      */
     public HyperlinkType getType();
 }

Modified: poi/trunk/src/java/org/apache/poi/common/usermodel/HyperlinkType.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/common/usermodel/HyperlinkType.java?rev=1884158&r1=1884157&r2=1884158&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/common/usermodel/HyperlinkType.java (original)
+++ poi/trunk/src/java/org/apache/poi/common/usermodel/HyperlinkType.java Sun Dec  6 16:53:14 2020
@@ -16,9 +16,6 @@
 ==================================================================== */
 package org.apache.poi.common.usermodel;
 
-import java.util.HashMap;
-import java.util.Map;
-
 import org.apache.poi.util.Internal;
 
 /**
@@ -70,38 +67,13 @@ public enum HyperlinkType {
         this.code = code;
     }
     
-    private static final Map<Integer, HyperlinkType> map = new HashMap<>();
-    static {
-        for (HyperlinkType type : values()) {
-            map.put(type.getCode(), type);
-        }
-    }
-    
     /**
      * @deprecated POI 3.15 beta 3
      *
      * @return the old integer code for a HyperlinkType enum
      */
     @Internal(since="3.15 beta 3")
-    @Deprecated
-    public int getCode() {
+    int getCode() {
         return code;
     }
-    
-    /**
-     * @deprecated POI 3.15 beta 3
-     *
-     * @param code the old integer code
-     * @return the corresponding HyperlinkEnum, if it exists
-     * @throws IllegalArgumentException if {@code code} is not a valid HyperlinkType.
-     */
-    @Internal(since="3.15 beta 3")
-    @Deprecated
-    public static HyperlinkType forInt(int code) {
-        HyperlinkType type = map.get(code);
-        if (type == null) {
-            throw new IllegalArgumentException("Invalid type: " + code);
-        }
-        return type;
-    }
 }

Modified: poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFHyperlink.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFHyperlink.java?rev=1884158&r1=1884157&r2=1884158&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFHyperlink.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFHyperlink.java Sun Dec  6 16:53:14 2020
@@ -257,7 +257,6 @@ public class HSSFHyperlink implements Hy
      * Return the type of this hyperlink
      *
      * @return the type of this hyperlink
-     * @see HyperlinkType#forInt
      */
     @Override
     public HyperlinkType getType() {

Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFHyperlink.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFHyperlink.java?rev=1884158&r1=1884157&r2=1884158&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFHyperlink.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFHyperlink.java Sun Dec  6 16:53:14 2020
@@ -155,7 +155,6 @@ public class XSSFHyperlink implements Hy
      * Return the type of this hyperlink
      *
      * @return the type of this hyperlink
-     * @see HyperlinkType#forInt
      */
     @Override
     public HyperlinkType getType() {



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org