You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by freakyzoidberg <gi...@git.apache.org> on 2016/01/04 19:21:29 UTC

[GitHub] phoenix pull request: PHOENIX-2364 Fix Reverse timestamp row key

GitHub user freakyzoidberg opened a pull request:

    https://github.com/apache/phoenix/pull/146

    PHOENIX-2364 Fix Reverse timestamp row key

    When inverting the millisecond part of a Timestamp key the offset should be reset.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/freakyzoidberg/phoenix master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/146.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #146
    
----
commit 921f6c67e521214c5d4eb8203f952eb904128bd8
Author: Pierre Lacave <pi...@lacave.me>
Date:   2016-01-04T18:20:13Z

    PHOENIX-2364 Fix Reverse timestamp row key

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] phoenix pull request: PHOENIX-2364 Fix Reverse timestamp row key

Posted by JamesRTaylor <gi...@git.apache.org>.
Github user JamesRTaylor commented on the pull request:

    https://github.com/apache/phoenix/pull/146#issuecomment-168795121
  
    Thanks for the patch, @freakyzoidberg. @samarthjain - would you mind reviewing and committing? It looks good to me. Probably worth making a quick pass through the code for calls to SortOrder.invert() and make sure we're setting the offset as is done in this patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---