You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/12 13:50:49 UTC
[GitHub] codecov-io commented on issue #5608: make some text localizable
codecov-io commented on issue #5608: make some text localizable
URL: https://github.com/apache/incubator-superset/pull/5608#issuecomment-412344269
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5608?src=pr&el=h1) Report
> Merging [#5608](https://codecov.io/gh/apache/incubator-superset/pull/5608?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d1ef81f1027e1712a222b95088a88af21b941e53?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `88%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5608/graphs/tree.svg?height=150&src=pr&token=KsB0fHcx6l&width=650)](https://codecov.io/gh/apache/incubator-superset/pull/5608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5608 +/- ##
==========================================
+ Coverage 63.59% 63.62% +0.03%
==========================================
Files 359 359
Lines 22799 22821 +22
Branches 2533 2533
==========================================
+ Hits 14499 14521 +22
Misses 8285 8285
Partials 15 15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5608?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/explore/visTypes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5608/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3Zpc1R5cGVzLmpzeA==) | `57.14% <ø> (ø)` | :arrow_up: |
| [...sets/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5608/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRGlzcGxheVF1ZXJ5QnV0dG9uLmpzeA==) | `73.84% <ø> (ø)` | :arrow_up: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/5608/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `64.34% <ø> (ø)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/5608/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.24% <ø> (ø)` | :arrow_up: |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5608/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQW5ub3RhdGlvbkxheWVyQ29udHJvbC5qc3g=) | `38.46% <0%> (ø)` | :arrow_up: |
| [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/5608/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `75.55% <100%> (+7.9%)` | :arrow_up: |
| [...nents/gridComponents/new/DraggableNewComponent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5608/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9uZXcvRHJhZ2dhYmxlTmV3Q29tcG9uZW50LmpzeA==) | `100% <100%> (ø)` | :arrow_up: |
| [...set/assets/src/dashboard/components/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5608/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9TbGljZUFkZGVyLmpzeA==) | `86.04% <100%> (+0.16%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5608/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.99% <100%> (+0.15%)` | :arrow_up: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5608/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQW5ub3RhdGlvbkxheWVyLmpzeA==) | `23.03% <33.33%> (+0.37%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5608?src=pr&el=footer). Last update [d1ef81f...bd02680](https://codecov.io/gh/apache/incubator-superset/pull/5608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org