You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by da...@apache.org on 2015/06/17 22:20:53 UTC
[3/3] git commit: updated refs/heads/4.5 to 4d096ea
CLOUDSTACK-8537 test for the sake of testing the fix seems so trivial but no testing is available for it at all. when bugs arise test extension should be the start point here.
Signed-off-by: Daan Hoogland <da...@gmail.com>
This closes #357
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/4d096ea0
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/4d096ea0
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/4d096ea0
Branch: refs/heads/4.5
Commit: 4d096ea0e10906138747fb2643a8fa84b5f11fd1
Parents: 6e3c6e8
Author: Daan Hoogland <da...@gmail.com>
Authored: Mon Jun 15 16:11:36 2015 +0200
Committer: Daan Hoogland <da...@gmail.com>
Committed: Wed Jun 17 22:20:13 2015 +0200
----------------------------------------------------------------------
.../com/cloud/server/ManagementServerImpl.java | 8 +--
.../cloud/server/ManagementServerImplTest.java | 67 ++++++++++++++++++++
2 files changed, 71 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/4d096ea0/server/src/com/cloud/server/ManagementServerImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/server/ManagementServerImpl.java b/server/src/com/cloud/server/ManagementServerImpl.java
index 08fd9e9..5946b29 100755
--- a/server/src/com/cloud/server/ManagementServerImpl.java
+++ b/server/src/com/cloud/server/ManagementServerImpl.java
@@ -745,7 +745,7 @@ public class ManagementServerImpl extends ManagerBase implements ManagementServe
@Inject
private InstanceGroupDao _vmGroupDao;
@Inject
- private SSHKeyPairDao _sshKeyPairDao;
+ protected SSHKeyPairDao _sshKeyPairDao;
@Inject
private LoadBalancerDao _loadbalancerDao;
@Inject
@@ -3645,7 +3645,7 @@ public class ManagementServerImpl extends ManagerBase implements ManagementServe
* @param owner
* @throws InvalidParameterValueException
*/
- private void checkForKeyByName(RegisterSSHKeyPairCmd cmd, Account owner) throws InvalidParameterValueException {
+ protected void checkForKeyByName(RegisterSSHKeyPairCmd cmd, Account owner) throws InvalidParameterValueException {
SSHKeyPairVO existingPair = _sshKeyPairDao.findByName(owner.getAccountId(), owner.getDomainId(), cmd.getName());
if (existingPair != null) {
throw new InvalidParameterValueException("A key pair with name '" + cmd.getName() + "' already exists for this account.");
@@ -3679,7 +3679,7 @@ public class ManagementServerImpl extends ManagerBase implements ManagementServe
* @param cmd
* @return
*/
- private Account getOwner(RegisterSSHKeyPairCmd cmd) {
+ protected Account getOwner(RegisterSSHKeyPairCmd cmd) {
Account caller = getCaller();
Account owner = _accountMgr.finalizeOwner(caller, cmd.getAccountName(), cmd.getDomainId(), cmd.getProjectId());
@@ -3689,7 +3689,7 @@ public class ManagementServerImpl extends ManagerBase implements ManagementServe
/**
* @return
*/
- private Account getCaller() {
+ protected Account getCaller() {
Account caller = CallContext.current().getCallingAccount();
return caller;
}
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/4d096ea0/server/test/com/cloud/server/ManagementServerImplTest.java
----------------------------------------------------------------------
diff --git a/server/test/com/cloud/server/ManagementServerImplTest.java b/server/test/com/cloud/server/ManagementServerImplTest.java
new file mode 100644
index 0000000..1e530e6
--- /dev/null
+++ b/server/test/com/cloud/server/ManagementServerImplTest.java
@@ -0,0 +1,67 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.server;
+
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.Spy;
+import org.mockito.runners.MockitoJUnitRunner;
+
+import org.apache.cloudstack.api.command.user.ssh.RegisterSSHKeyPairCmd;
+
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.user.Account;
+import com.cloud.user.SSHKeyPairVO;
+import com.cloud.user.dao.SSHKeyPairDao;
+
+@RunWith(MockitoJUnitRunner.class)
+public class ManagementServerImplTest {
+
+ @Mock
+ RegisterSSHKeyPairCmd regCmd;
+ @Mock
+ SSHKeyPairVO existingPair;
+ @Mock
+ Account account;
+ @Mock
+ SSHKeyPairDao sshKeyPairDao;
+ ManagementServerImpl ms = new ManagementServerImpl();
+ @Spy
+ ManagementServerImpl spy;
+
+ @Test(expected = InvalidParameterValueException.class)
+ public void testExistingPairRegistration() {
+ String accountName = "account";
+ String publicKeyString = "very public";
+ // setup owner with domainid
+ Mockito.doReturn(account).when(spy).getCaller();
+ Mockito.doReturn(account).when(spy).getOwner(regCmd);
+ // mock _sshKeyPairDao.findByName to return null
+ Mockito.doNothing().when(spy).checkForKeyByName(regCmd, account);
+ // mock _sshKeyPairDao.findByPublicKey to return a known object
+ Mockito.doReturn(accountName).when(regCmd).getAccountName();
+ Mockito.doReturn(publicKeyString).when(regCmd).getPublicKey();
+ Mockito.doReturn("name").when(regCmd).getName();
+ spy._sshKeyPairDao = sshKeyPairDao;
+ Mockito.doReturn(1L).when(account).getAccountId();
+ Mockito.doReturn(1L).when(account).getDomainId();
+ Mockito.doReturn(existingPair).when(sshKeyPairDao).findByPublicKey(1L, 1L, publicKeyString);
+ spy.registerSSHKeyPair(regCmd);
+ }
+}