You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ch...@apache.org on 2018/06/12 12:32:25 UTC

flink git commit: [FLINK-8946][metrics] Do not close TM MetricGroup on JobManager failover

Repository: flink
Updated Branches:
  refs/heads/release-1.4 0469227c8 -> 8b046fafb


[FLINK-8946][metrics] Do not close TM MetricGroup on JobManager failover

This closes #6060.


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/8b046faf
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/8b046faf
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/8b046faf

Branch: refs/heads/release-1.4
Commit: 8b046fafb6ee77a86e360f6b792e7f73399239bd
Parents: 0469227
Author: yanghua <ya...@gmail.com>
Authored: Wed May 23 17:42:04 2018 +0800
Committer: zentol <ch...@apache.org>
Committed: Tue Jun 12 14:31:36 2018 +0200

----------------------------------------------------------------------
 .../org/apache/flink/runtime/taskmanager/TaskManager.scala    | 7 -------
 1 file changed, 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/8b046faf/flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
----------------------------------------------------------------------
diff --git a/flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala b/flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
index 9979618..578ae2c 100644
--- a/flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
+++ b/flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
@@ -1051,13 +1051,6 @@ class TaskManager(
     if (network.getKvStateRegistry != null) {
       network.getKvStateRegistry.unregisterListener()
     }
-    
-    // failsafe shutdown of the metrics registry
-    try {
-      taskManagerMetricGroup.close()
-    } catch {
-      case t: Exception => log.warn("TaskManagerMetricGroup could not be closed successfully.", t)
-    }
   }
 
   protected def handleJobManagerDisconnect(msg: String): Unit = {