You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/11 21:28:40 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4418: Fix
potential resource leak in the way we close a collection of closeables
codecov-io edited a comment on issue #4418: Fix potential resource leak in the way we close a collection of closeables
URL: https://github.com/apache/incubator-pinot/pull/4418#issuecomment-510276514
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4418?src=pr&el=h1) Report
> Merging [#4418](https://codecov.io/gh/apache/incubator-pinot/pull/4418?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/07e2c721d964c290888c66bf7750e6b2067d4ca1?src=pr&el=desc) will **increase** coverage by `9.76%`.
> The diff coverage is `71.87%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4418/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4418?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4418 +/- ##
============================================
+ Coverage 55.72% 65.48% +9.76%
Complexity 20 20
============================================
Files 1068 1075 +7
Lines 55557 55852 +295
Branches 7910 7969 +59
============================================
+ Hits 30957 36575 +5618
+ Misses 22202 16652 -5550
- Partials 2398 2625 +227
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4418?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...riter/impl/FixedByteSingleValueMultiColWriter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby93cml0ZXIvaW1wbC9GaXhlZEJ5dGVTaW5nbGVWYWx1ZU11bHRpQ29sV3JpdGVyLmphdmE=) | `84.78% <ø> (-0.33%)` | `0 <0> (ø)` | |
| [...or/impl/inv/OffHeapBitmapInvertedIndexCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9pbnYvT2ZmSGVhcEJpdG1hcEludmVydGVkSW5kZXhDcmVhdG9yLmphdmE=) | `86.53% <100%> (+0.53%)` | `0 <0> (ø)` | :arrow_down: |
| [...ment/creator/impl/SegmentColumnarIndexCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50Q29sdW1uYXJJbmRleENyZWF0b3IuamF2YQ==) | `87.15% <100%> (+0.41%)` | `0 <0> (ø)` | :arrow_down: |
| [...impl/fwd/SingleValueSortedForwardIndexCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9md2QvU2luZ2xlVmFsdWVTb3J0ZWRGb3J3YXJkSW5kZXhDcmVhdG9yLmphdmE=) | `90% <100%> (-4.74%)` | `0 <0> (ø)` | |
| [.../java/org/apache/pinot/common/utils/FileUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvRmlsZVV0aWxzLmphdmE=) | `40% <50%> (+15%)` | `0 <0> (ø)` | :arrow_down: |
| [...broker/requesthandler/PinotQueryParserFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvUGlub3RRdWVyeVBhcnNlckZhY3RvcnkuamF2YQ==) | `50% <0%> (ø)` | `0% <0%> (?)` | |
| [...g/apache/pinot/sql/parsers/CalciteSqlCompiler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsQ29tcGlsZXIuamF2YQ==) | `100% <0%> (ø)` | `0% <0%> (?)` | |
| [...ot/parsers/utils/BrokerRequestComparisonUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wYXJzZXJzL3V0aWxzL0Jyb2tlclJlcXVlc3RDb21wYXJpc29uVXRpbHMuamF2YQ==) | `26.86% <0%> (ø)` | `0% <0%> (?)` | |
| [...che/pinot/sql/parsers/SqlCompilationException.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9TcWxDb21waWxhdGlvbkV4Y2VwdGlvbi5qYXZh) | `50% <0%> (ø)` | `0% <0%> (?)` | |
| [...pinot/broker/requesthandler/PinotQueryRequest.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvUGlub3RRdWVyeVJlcXVlc3QuamF2YQ==) | `60% <0%> (ø)` | `0% <0%> (?)` | |
| ... and [335 more](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4418?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4418?src=pr&el=footer). Last update [07e2c72...f538776](https://codecov.io/gh/apache/incubator-pinot/pull/4418?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org