You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2016/02/26 11:59:25 UTC
[GitHub] flink pull request: [hotfix] [build] Disable exclusion rules when ...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/1719
[hotfix] [build] Disable exclusion rules when using build-jar maven profile
Disables the exclusion rules when using the quickstarts.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixQuickstarts
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1719.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1719
----
commit 1d8f6ba66459b81088d8686cb36c876300854110
Author: Till Rohrmann <tr...@apache.org>
Date: 2016-02-26T10:57:21Z
[hotfix] [build] Disable exclusion rules when using build-jar maven profile.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix] [build] Disable exclusion rules when ...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1719#issuecomment-189375282
+1 to merge this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix] [build] Disable exclusion rules when ...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1719#issuecomment-189447408
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix] [build] Disable exclusion rules when ...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1719#discussion_r54230298
--- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml ---
@@ -89,6 +89,61 @@ under the License.
</dependency>
</dependencies>
+ <profiles>
+ <profile>
+ <!-- A profile that does everyting correctly:
--- End diff --
typo: should be everyt**h**ing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix] [build] Disable exclusion rules when ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1719#discussion_r54251279
--- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml ---
@@ -89,6 +89,61 @@ under the License.
</dependency>
</dependencies>
+ <profiles>
+ <profile>
+ <!-- A profile that does everyting correctly:
--- End diff --
Good catch. Will replace it with @StephanEwen's proposal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix] [build] Disable exclusion rules when ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1719
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix] [build] Disable exclusion rules when ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1719#issuecomment-189353549
Concerning the `maven-antrun-plugin`, I think it wouldn't hurt to include it. However, it might also simply disappear under all the other maven console output.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix] [build] Disable exclusion rules when ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1719#discussion_r54230573
--- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml ---
@@ -89,6 +89,61 @@ under the License.
</dependency>
</dependencies>
+ <profiles>
+ <profile>
+ <!-- A profile that does everyting correctly:
--- End diff --
How about writing `Profile for packaging correct JAR files`. That let's people know it is actually for JAR files ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix] [build] Disable exclusion rules when ...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1719#issuecomment-189375154
I'm okay with not including it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix] [build] Disable exclusion rules when ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1719#issuecomment-189352536
Thanks for the review @zentol, @StephanEwen and @rmetzger. I've changed the comment.
Concerning the documentation, there is already a note about the `build-jar` profile. In fact that's also how we describe to build the fat jar in our [quickstart guide](https://ci.apache.org/projects/flink/flink-docs-master/quickstart/java_api_quickstart.html#build-project). Do you think that it should be put more prominently?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix] [build] Disable exclusion rules when ...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1719#issuecomment-189223135
Can also also add a note to the documentation about the build-jar profile?
This is just an idea, but maybe we could add the following plugin to the quickstarts:
```xml
<plugin>
<artifactId>maven-antrun-plugin</artifactId>
<executions>
<execution>
<phase>generate-resources</phase>
<goals>
<goal>run</goal>
</goals>
<configuration>
<tasks>
<echo>${line.separator}
${line.separator}Please use the "-Pbuild-jar" profile for creating a fat-jar.
${line.separator}${line.separator}${line.separator}</echo>
</tasks>
</configuration>
</execution>
</executions>
</plugin>
```
this leads to the following output:
```
obert@robert-da ...nk-workdir/flink-state-watermarks-1.0 (git)-[no_kryo] % mvn install
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Flink Quickstart Job 1.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-antrun-plugin:1.3:run (default) @ flink-state-watermarks-1.0 ---
[INFO] Executing tasks
[echo]
[echo]
[echo]
[echo] Please use the "-Pbuild-jar" profile for creating a fat-jar.
[echo]
[echo]
[INFO] Executed tasks
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ flink-state-watermarks-1.0 ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO]
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ flink-state-watermarks-1.0 ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---