You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2012/06/23 14:09:02 UTC
[Bug 53458] New: simple bug in HyphenationTreeCache
https://issues.apache.org/bugzilla/show_bug.cgi?id=53458
Priority: P2
Bug ID: 53458
Assignee: fop-dev@xmlgraphics.apache.org
Summary: simple bug in HyphenationTreeCache
Severity: normal
Classification: Unclassified
Reporter: info@dvholten.de
Hardware: PC
Status: NEW
Version: all
Component: page-master/layout
Product: Fop
in method constructUserKey() i found this code near line 82:
if (hyphPatNames != null) {
String key = constructLlccKey(lang, country);
key.replace('_', '-'); <<<<<<<< ======= !!!!
userKey = (String) hyphPatNames.get(key);
}
return userKey;
it should be
key = key.replace('_', '-');
the code as it is now is without effect.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53458] simple bug in HyphenationTreeCache
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53458
info@dvholten.de changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--- Comment #1 from info@dvholten.de ---
i found that a specific findbugs-check for this is disabled in file
'findbugs-exclude.xml'.
findbugs is right - the code is wrong
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53458] simple bug in HyphenationTreeCache
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53458
--- Comment #5 from Glenn Adams <ga...@apache.org> ---
(In reply to comment #4)
> when you fix the two typos of 'hyphneation' in the same file i'd completly
> happy.
done!
> providing a testcase for this might be tricky - the bug is 'deep inside' and
> i have no idea how to influence hyphenation in fop.
well, if you have any thoughts on this in the future, please say so
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53458] simple bug in HyphenationTreeCache
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53458
Glenn Adams <ga...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #2 from Glenn Adams <ga...@apache.org> ---
(In reply to comment #1)
> i found that a specific findbugs-check for this is disabled in file
> 'findbugs-exclude.xml'.
>
> findbugs is right - the code is wrong
thanks for tracking this down; that is one of the problems with generating
exclusions automatically and not going back to review them; reviewing the
findbugs exclusions remains a TBD;
could you attach a minimal regression test we can add to test the condition
addressed by this fix?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53458] simple bug in HyphenationTreeCache
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53458
Glenn Adams <ga...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Glenn Adams <ga...@apache.org> ---
patch applied at http://svn.apache.org/viewvc?rev=1353320&view=rev
thanks dieter! please review and close if satisfied... also, if you wish to
submit a test case, it would be appreciated...
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53458] simple bug in HyphenationTreeCache
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53458
info@dvholten.de changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53458] simple bug in HyphenationTreeCache
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53458
--- Comment #4 from info@dvholten.de ---
when you fix the two typos of 'hyphneation' in the same file i'd completly
happy.
providing a testcase for this might be tricky - the bug is 'deep inside' and i
have no idea how to influence hyphenation in fop.
--
You are receiving this mail because:
You are the assignee for the bug.