You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2018/07/27 10:41:00 UTC

[jira] [Commented] (IO-582) ObservableInputStream.Observer are package-private

    [ https://issues.apache.org/jira/browse/IO-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559554#comment-16559554 ] 

Sebb commented on IO-582:
-------------------------

No need; you can extend Observer with your own class and pass that to ObservableInputStream#add(Observer)

See for example MessageDigestCalculatingInputStream.MessageDigestMaintainingObserver

> ObservableInputStream.Observer are package-private
> --------------------------------------------------
>
>                 Key: IO-582
>                 URL: https://issues.apache.org/jira/browse/IO-582
>             Project: Commons IO
>          Issue Type: Bug
>          Components: Streams/Writers
>    Affects Versions: 2.6
>            Reporter: Bruno Palos
>            Priority: Minor
>
> Hi,
> According with the documentation of `ObservableInputStream` and `ObservableInputStream.Observer`, it should be possible to use those classes as part of the `commons-io` utilities. However, `ObservableInputStream.Observer`'s methods are package private and can't be extended outside the project's source code.
> My suggestion is to make `ObservableInputStream.Observer`'s methods protected.
> I'm happy to open a PR for this.
> Thank you
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)