You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/03/27 10:04:54 UTC
[GitHub] [skywalking] LIU-WEI-git opened a new pull request #8755: Iotdb data converter
LIU-WEI-git opened a new pull request #8755:
URL: https://github.com/apache/skywalking/pull/8755
Refactor IoTDB storage plugin referring to PR#8684, add IoTDBDataConverter and fix ModifyCollectionInEnhancedForLoop bug. Bump up iotdb-session to 0.12.5.
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] LIU-WEI-git commented on a change in pull request #8755: Refactor IoTDB storage plugin and bump up iotdb-session to 0.12.5
Posted by GitBox <gi...@apache.org>.
LIU-WEI-git commented on a change in pull request #8755:
URL: https://github.com/apache/skywalking/pull/8755#discussion_r837530747
##########
File path: oap-server/server-storage-plugin/storage-iotdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/iotdb/query/IoTDBTopologyQueryDAO.java
##########
@@ -254,7 +254,7 @@
RowRecord rowRecord = wrapper.next();
List<Field> fields = rowRecord.getFields();
Call.CallDetail call = new Call.CallDetail();
- List<String> layerNames = Splitter.on(IoTDBClient.DOT)
+ List<String> layerNames = Splitter.on(IoTDBClient.DOT + "\"")
Review comment:
Dot (.) is the splitter in the database IoTDB. However, we use dot and double quotation marks (.") as the splitter in IoTDB storage plugin. In our schema design, every index field value will add double quotation marks and store in the path. This splitter could avoid error caused by serviceId and other index fields containing dot when transforming from query result to entity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] LIU-WEI-git closed pull request #8755: Refactor IoTDB storage plugin and bump up iotdb-session to 0.12.5
Posted by GitBox <gi...@apache.org>.
LIU-WEI-git closed pull request #8755:
URL: https://github.com/apache/skywalking/pull/8755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8755: Refactor IoTDB storage plugin and bump up iotdb-session to 0.12.5
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8755:
URL: https://github.com/apache/skywalking/pull/8755#discussion_r838330741
##########
File path: oap-server/server-storage-plugin/storage-iotdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/iotdb/query/IoTDBTopologyQueryDAO.java
##########
@@ -254,7 +254,7 @@
RowRecord rowRecord = wrapper.next();
List<Field> fields = rowRecord.getFields();
Call.CallDetail call = new Call.CallDetail();
- List<String> layerNames = Splitter.on(IoTDBClient.DOT)
+ List<String> layerNames = Splitter.on(IoTDBClient.DOT + "\"")
Review comment:
We did add the endpoint name and instance name because we are concerned about `too many candidates` for IoTDB. But in real cases, we may face performance issues when user wants to find an endpoint from 1m size data set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sonatype-lift[bot] commented on a change in pull request #8755: Refactor IoTDB storage plugin and bump up iotdb-session to 0.12.5
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on a change in pull request #8755:
URL: https://github.com/apache/skywalking/pull/8755#discussion_r837070991
##########
File path: oap-server/server-storage-plugin/storage-iotdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/iotdb/query/IoTDBTopologyQueryDAO.java
##########
@@ -39,6 +39,7 @@
import org.apache.skywalking.oap.server.core.source.DetectPoint;
import org.apache.skywalking.oap.server.core.storage.query.ITopologyQueryDAO;
import org.apache.skywalking.oap.server.storage.plugin.iotdb.IoTDBClient;
+import org.apache.skywalking.oap.server.storage.plugin.iotdb.utils.IoTDBUtils;
@Slf4j
@RequiredArgsConstructor
Review comment:
*SameNameButDifferent:* The name `@RequiredArgsConstructor` refers to [java.lang.SuppressWarnings, lombok.Generated, org.apache.skywalking.oap.server.storage.plugin.iotdb.IoTDBClient] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity. [(details)](https://errorprone.info/bugpattern/SameNameButDifferent)
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)
##########
File path: oap-server/server-storage-plugin/storage-iotdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/iotdb/query/IoTDBTopologyQueryDAO.java
##########
@@ -39,6 +39,7 @@
import org.apache.skywalking.oap.server.core.source.DetectPoint;
import org.apache.skywalking.oap.server.core.storage.query.ITopologyQueryDAO;
import org.apache.skywalking.oap.server.storage.plugin.iotdb.IoTDBClient;
+import org.apache.skywalking.oap.server.storage.plugin.iotdb.utils.IoTDBUtils;
@Slf4j
Review comment:
*SameNameButDifferent:* The name `@Slf4j` refers to [java.lang.SuppressWarnings, lombok.Generated, org.slf4j.Logger, org.slf4j.LoggerFactory] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity. [(details)](https://errorprone.info/bugpattern/SameNameButDifferent)
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)
##########
File path: oap-server/server-storage-plugin/storage-iotdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/iotdb/query/IoTDBTopologyQueryDAO.java
##########
@@ -158,7 +159,7 @@
List<Field> fields = rowRecord.getFields();
Call.CallDetail call = new Call.CallDetail();
String[] layerNames = fields.get(0).getStringValue().split("\\" + IoTDBClient.DOT + "\"");
Review comment:
*StringSplitter:* String.split(String) has surprising behavior [(details)](https://errorprone.info/bugpattern/StringSplitter)
```suggestion
List<String> layerNames = Splitter.onPattern("\\" + IoTDBClient.DOT + "\"").splitToList(fields.get(0).getStringValue());
```
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] LIU-WEI-git commented on a change in pull request #8755: Refactor IoTDB storage plugin and bump up iotdb-session to 0.12.5
Posted by GitBox <gi...@apache.org>.
LIU-WEI-git commented on a change in pull request #8755:
URL: https://github.com/apache/skywalking/pull/8755#discussion_r837636784
##########
File path: oap-server/server-storage-plugin/storage-iotdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/iotdb/query/IoTDBTopologyQueryDAO.java
##########
@@ -254,7 +254,7 @@
RowRecord rowRecord = wrapper.next();
List<Field> fields = rowRecord.getFields();
Call.CallDetail call = new Call.CallDetail();
- List<String> layerNames = Splitter.on(IoTDBClient.DOT)
+ List<String> layerNames = Splitter.on(IoTDBClient.DOT + "\"")
Review comment:
If here is a service_traffic with two index fields service_id and layer whose value is `ZTJlLXNlcnZpY2UtcHJvdmlkZXI=.2` and `2`. In our schema, we store it as `root.skywalking.service_traffic."ZTJlLXNlcnZpY2UtcHJvdmlkZXI=.2"."2"`. If we use dot as the splitter, we will get `root`, `skywalking`, `service_traffic`, `"ZTJlLXNlcnZpY2UtcHJvdmlkZXI=`, `2"`, `"2"`. The service_id value is splitted into two parts, `"ZTJlLXNlcnZpY2UtcHJvdmlkZXI=` and `2"`, which is not what we want. In order to avoid index value containing dot, we use dot and double quotation marks (.") as the splitter in IoTDB storage plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8755: Refactor IoTDB storage plugin and bump up iotdb-session to 0.12.5
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8755:
URL: https://github.com/apache/skywalking/pull/8755#discussion_r837588055
##########
File path: oap-server/server-storage-plugin/storage-iotdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/iotdb/query/IoTDBTopologyQueryDAO.java
##########
@@ -254,7 +254,7 @@
RowRecord rowRecord = wrapper.next();
List<Field> fields = rowRecord.getFields();
Call.CallDetail call = new Call.CallDetail();
- List<String> layerNames = Splitter.on(IoTDBClient.DOT)
+ List<String> layerNames = Splitter.on(IoTDBClient.DOT + "\"")
Review comment:
Could you share some examples? I am a little not following yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8755: Refactor IoTDB storage plugin and bump up iotdb-session to 0.12.5
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8755:
URL: https://github.com/apache/skywalking/pull/8755#discussion_r837583668
##########
File path: oap-server/server-storage-plugin/storage-iotdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/iotdb/query/IoTDBTopologyQueryDAO.java
##########
@@ -39,6 +39,7 @@
import org.apache.skywalking.oap.server.core.source.DetectPoint;
import org.apache.skywalking.oap.server.core.storage.query.ITopologyQueryDAO;
import org.apache.skywalking.oap.server.storage.plugin.iotdb.IoTDBClient;
+import org.apache.skywalking.oap.server.storage.plugin.iotdb.utils.IoTDBUtils;
@Slf4j
@RequiredArgsConstructor
Review comment:
@jlstephens89 I have synced once, and just sync again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8755: Refactor IoTDB storage plugin and bump up iotdb-session to 0.12.5
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8755:
URL: https://github.com/apache/skywalking/pull/8755#discussion_r837060296
##########
File path: CHANGES.md
##########
@@ -124,7 +124,8 @@ Release Notes.
* Add complexity limitation for GraphQL query to avoid malicious query.
* Add `Column.shardingKeyIdx` for column definition for BanyanDB.
* Fix the configuration of `Aggregation` and `GC Count` metrics for oap self observability
-
+* Refactor IoTDB storage plugin, add IoTDBDataConverter and fix ModifyCollectionInEnhancedForLoop bug.
Review comment:
Please move this to the end of backend change. This is separating one change log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sonatype-lift[bot] commented on a change in pull request #8755: Refactor IoTDB storage plugin and bump up iotdb-session to 0.12.5
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on a change in pull request #8755:
URL: https://github.com/apache/skywalking/pull/8755#discussion_r835887132
##########
File path: oap-server/server-storage-plugin/storage-iotdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/iotdb/IoTDBClient.java
##########
@@ -32,18 +30,17 @@
import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
import org.apache.iotdb.tsfile.read.common.Field;
import org.apache.iotdb.tsfile.read.common.RowRecord;
-import org.apache.skywalking.oap.server.core.analysis.TimeBucket;
-import org.apache.skywalking.oap.server.core.analysis.manual.log.LogRecord;
-import org.apache.skywalking.oap.server.core.browser.manual.errorlog.BrowserErrorLogRecord;
-import org.apache.skywalking.oap.server.core.management.ui.template.UITemplate;
import org.apache.skywalking.oap.server.core.storage.StorageData;
-import org.apache.skywalking.oap.server.core.storage.type.HashMapConverter;
+import org.apache.skywalking.oap.server.core.storage.type.Convert2Entity;
import org.apache.skywalking.oap.server.core.storage.type.StorageBuilder;
import org.apache.skywalking.oap.server.library.client.Client;
import org.apache.skywalking.oap.server.library.client.healthcheck.DelegatedHealthChecker;
import org.apache.skywalking.oap.server.library.client.healthcheck.HealthCheckable;
import org.apache.skywalking.oap.server.library.util.HealthChecker;
import org.apache.skywalking.oap.server.storage.plugin.iotdb.base.IoTDBInsertRequest;
+import org.apache.skywalking.oap.server.storage.plugin.iotdb.utils.IoTDBDataConverter;
+
+import static org.apache.skywalking.oap.server.storage.plugin.iotdb.utils.IoTDBUtils.indexValue2LayerName;
@Slf4j
Review comment:
*SameNameButDifferent:* The name `@Slf4j` refers to [java.lang.SuppressWarnings, lombok.Generated, org.slf4j.Logger, org.slf4j.LoggerFactory] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity. [(details)](https://errorprone.info/bugpattern/SameNameButDifferent)
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)
##########
File path: oap-server/server-storage-plugin/storage-iotdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/iotdb/base/IoTDBInsertRequest.java
##########
@@ -50,59 +45,23 @@
private List<TSDataType> measurementTypes;
private List<Object> measurementValues;
Review comment:
*SameNameButDifferent:* The name `measurementValues;` refers to [java.lang.SuppressWarnings, lombok.Generated, java.util.List, java.lang.Object] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity. [(details)](https://errorprone.info/bugpattern/SameNameButDifferent)
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)
##########
File path: oap-server/server-storage-plugin/storage-iotdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/iotdb/base/IoTDBInsertRequest.java
##########
@@ -50,59 +45,23 @@
private List<TSDataType> measurementTypes;
Review comment:
*SameNameButDifferent:* The name `measurementTypes;` refers to [java.lang.SuppressWarnings, lombok.Generated, java.util.List, org.apache.iotdb.tsfile.file.metadata.enums.TSDataType] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity. [(details)](https://errorprone.info/bugpattern/SameNameButDifferent)
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)
##########
File path: oap-server/server-storage-plugin/storage-iotdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/iotdb/base/IoTDBInsertRequest.java
##########
@@ -19,23 +19,18 @@
package org.apache.skywalking.oap.server.storage.plugin.iotdb.base;
import java.util.ArrayList;
-import java.util.Iterator;
import java.util.List;
-import java.util.Map;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import lombok.extern.slf4j.Slf4j;
import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
import org.apache.skywalking.oap.server.core.storage.StorageData;
-import org.apache.skywalking.oap.server.core.storage.type.HashMapConverter;
import org.apache.skywalking.oap.server.core.storage.type.StorageBuilder;
-import org.apache.skywalking.oap.server.core.storage.type.StorageDataComplexObject;
import org.apache.skywalking.oap.server.library.client.request.InsertRequest;
import org.apache.skywalking.oap.server.library.client.request.UpdateRequest;
-import org.apache.skywalking.oap.server.storage.plugin.iotdb.IoTDBClient;
-import org.apache.skywalking.oap.server.storage.plugin.iotdb.IoTDBIndexes;
import org.apache.skywalking.oap.server.storage.plugin.iotdb.IoTDBTableMetaInfo;
+import org.apache.skywalking.oap.server.storage.plugin.iotdb.utils.IoTDBDataConverter;
@Getter
@Setter
Review comment:
*SameNameButDifferent:* The name `@Setter` refers to [java.lang.SuppressWarnings, lombok.Generated, java.lang.String, java.util.List, org.apache.iotdb.tsfile.file.metadata.enums.TSDataType, java.lang.Object] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity. [(details)](https://errorprone.info/bugpattern/SameNameButDifferent)
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)
##########
File path: oap-server/server-storage-plugin/storage-iotdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/iotdb/base/IoTDBInsertRequest.java
##########
@@ -50,59 +45,23 @@
Review comment:
*SameNameButDifferent:* The name `@ToString` refers to [java.lang.Override, java.lang.SuppressWarnings, lombok.Generated, java.lang.String] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity. [(details)](https://errorprone.info/bugpattern/SameNameButDifferent)
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #8755: Refactor IoTDB storage plugin and bump up iotdb-session to 0.12.5
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #8755:
URL: https://github.com/apache/skywalking/pull/8755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] jlstephens89 commented on a change in pull request #8755: Refactor IoTDB storage plugin and bump up iotdb-session to 0.12.5
Posted by GitBox <gi...@apache.org>.
jlstephens89 commented on a change in pull request #8755:
URL: https://github.com/apache/skywalking/pull/8755#discussion_r837536932
##########
File path: oap-server/server-storage-plugin/storage-iotdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/iotdb/query/IoTDBTopologyQueryDAO.java
##########
@@ -39,6 +39,7 @@
import org.apache.skywalking.oap.server.core.source.DetectPoint;
import org.apache.skywalking.oap.server.core.storage.query.ITopologyQueryDAO;
import org.apache.skywalking.oap.server.storage.plugin.iotdb.IoTDBClient;
+import org.apache.skywalking.oap.server.storage.plugin.iotdb.utils.IoTDBUtils;
@Slf4j
@RequiredArgsConstructor
Review comment:
@wu-sheng It looks like this PR was created before the config change was merged to main so probably need to rebase this branch on main to pick up on those changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8755: Refactor IoTDB storage plugin and bump up iotdb-session to 0.12.5
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8755:
URL: https://github.com/apache/skywalking/pull/8755#discussion_r838313013
##########
File path: oap-server/server-storage-plugin/storage-iotdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/iotdb/query/IoTDBTopologyQueryDAO.java
##########
@@ -254,7 +254,7 @@
RowRecord rowRecord = wrapper.next();
List<Field> fields = rowRecord.getFields();
Call.CallDetail call = new Call.CallDetail();
- List<String> layerNames = Splitter.on(IoTDBClient.DOT)
+ List<String> layerNames = Splitter.on(IoTDBClient.DOT + "\"")
Review comment:
Is this index mechanism working everywhere? Be careful for trace/log's tags, or endpoint name. It is common to have `.` and `"` from there. I think IoTDB community should improve this, it is hard to choose and separate fields in multi values index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8755: Refactor IoTDB storage plugin and bump up iotdb-session to 0.12.5
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8755:
URL: https://github.com/apache/skywalking/pull/8755#discussion_r838331609
##########
File path: oap-server/server-storage-plugin/storage-iotdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/iotdb/query/IoTDBTopologyQueryDAO.java
##########
@@ -254,7 +254,7 @@
RowRecord rowRecord = wrapper.next();
List<Field> fields = rowRecord.getFields();
Call.CallDetail call = new Call.CallDetail();
- List<String> layerNames = Splitter.on(IoTDBClient.DOT)
+ List<String> layerNames = Splitter.on(IoTDBClient.DOT + "\"")
Review comment:
Anyway, we have known, IoTDB as storage is not used in the product mostly for now, because we didn't receive any report about this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #8755: Refactor IoTDB storage plugin and bump up iotdb-session to 0.12.5
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #8755:
URL: https://github.com/apache/skywalking/pull/8755#issuecomment-1082481640
https://github.com/apache/skywalking/pull/8761 is going to be merged, please check its changes and new uses of `MultiGet`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8755: Refactor IoTDB storage plugin and bump up iotdb-session to 0.12.5
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8755:
URL: https://github.com/apache/skywalking/pull/8755#discussion_r837103338
##########
File path: oap-server/server-storage-plugin/storage-iotdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/iotdb/query/IoTDBTopologyQueryDAO.java
##########
@@ -39,6 +39,7 @@
import org.apache.skywalking.oap.server.core.source.DetectPoint;
import org.apache.skywalking.oap.server.core.storage.query.ITopologyQueryDAO;
import org.apache.skywalking.oap.server.storage.plugin.iotdb.IoTDBClient;
+import org.apache.skywalking.oap.server.storage.plugin.iotdb.utils.IoTDBUtils;
@Slf4j
@RequiredArgsConstructor
Review comment:
@jlstephens89 I think you have added `SameNameButDifferent` in ignoreRules, but this is still showing up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8755: Refactor IoTDB storage plugin and bump up iotdb-session to 0.12.5
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8755:
URL: https://github.com/apache/skywalking/pull/8755#discussion_r837509977
##########
File path: oap-server/server-storage-plugin/storage-iotdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/iotdb/query/IoTDBTopologyQueryDAO.java
##########
@@ -254,7 +254,7 @@
RowRecord rowRecord = wrapper.next();
List<Field> fields = rowRecord.getFields();
Call.CallDetail call = new Call.CallDetail();
- List<String> layerNames = Splitter.on(IoTDBClient.DOT)
+ List<String> layerNames = Splitter.on(IoTDBClient.DOT + "\"")
Review comment:
What is the splitter in the database?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] LIU-WEI-git commented on a change in pull request #8755: Refactor IoTDB storage plugin and bump up iotdb-session to 0.12.5
Posted by GitBox <gi...@apache.org>.
LIU-WEI-git commented on a change in pull request #8755:
URL: https://github.com/apache/skywalking/pull/8755#discussion_r838328966
##########
File path: oap-server/server-storage-plugin/storage-iotdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/iotdb/query/IoTDBTopologyQueryDAO.java
##########
@@ -254,7 +254,7 @@
RowRecord rowRecord = wrapper.next();
List<Field> fields = rowRecord.getFields();
Call.CallDetail call = new Call.CallDetail();
- List<String> layerNames = Splitter.on(IoTDBClient.DOT)
+ List<String> layerNames = Splitter.on(IoTDBClient.DOT + "\"")
Review comment:
Tags and endpoint name is not the index fields we choose, and they are regarded as measurements when writing to IoTDB. They will not touch this problem.
For now, we only choose various id, layer and service group as index, which are encoded based on a certain strategy or just an integer. They will not cause problem now, but we should face up to this potential problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org