You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Berlin <db...@dberlin.org> on 2005/11/14 14:58:30 UTC
Re: svn commit: r17328 -
branches/wc-propcaching/subversion/libsvn_wc
> >
> > if (is_empty)
> For present time svn_wc__has_props() used only in one place, in
> assemble_status() mostyle for optimize call to svn_wc__is_special(). I
> consider we should reconsider later necessity of this function.
You'll notice i made is_special use the cached props in the
has_properties patch, so when that goes in, it shouldn't be any speed
gain to not use svn_wc__is_special.
>
> --
> Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r17328 - branches/wc-propcaching/subversion/libsvn_wc
Posted by Ivan Zhakov <ch...@gmail.com>.
On 11/14/05, Daniel Berlin <db...@dberlin.org> wrote:
> > >
> > > if (is_empty)
> > For present time svn_wc__has_props() used only in one place, in
> > assemble_status() mostyle for optimize call to svn_wc__is_special(). I
> > consider we should reconsider later necessity of this function.
>
> You'll notice i made is_special use the cached props in the
> has_properties patch, so when that goes in, it shouldn't be any speed
> gain to not use svn_wc__is_special.
Yes, I see. This is because I was noticed it. I am only said that we
need TODO comment in svn_wc__has_props() because possible we didn't
this function.
--
Ivan Zhakov