You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Rohini Palaniswamy <ro...@gmail.com> on 2014/06/09 19:00:56 UTC
Re: Review Request 19929: OOZIE-1685: Oozie doesn’t process correctly workflows with a non-default name node
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19929/#review45089
-----------------------------------------------------------
Patch looks good. Just two minor comments.
core/src/main/java/org/apache/oozie/service/ShareLibService.java
<https://reviews.apache.org/r/19929/#comment79756>
Is constructing new FileSystem required? Can't the local variable "fs" be returned as is. The fs will access filesystem as the oozie user. But I guess that should be ok as it is only used for reading files.
core/src/test/java/org/apache/oozie/test/XTestCase.java
<https://reviews.apache.org/r/19929/#comment79757>
create - c lower case.
- Rohini Palaniswamy
On May 30, 2014, 2:32 p.m., Benjamin Zhitomirsky wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19929/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 2:32 p.m.)
>
>
> Review request for oozie.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> When <name-node> element in Oozie workflow specifies a name node different from the default one (specified in core-site.xml), the following functionality doesn’t work properly:
> ?Location of libraries specified via oozie.service.WorkflowAppService.system.libpath. Oozie first (during launcher configuration) tries to locate them using name node specified by the <name-node> element, but later during job submission it expects this path to be under the default Oozie name node
> ?Processing of the job-xml element if job xml is specified via absolute path. Oozie tries locate it under the default Oozie name node instead of the name-node specified in action.
>
> Specifying non-default name node makes a lot of sense in Azure environment, because it allows to submit the same job to different Hadoop clusters.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 40add2c
> core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java bb68b0e
> core/src/main/java/org/apache/oozie/service/ShareLibService.java 353b382
> core/src/main/java/org/apache/oozie/util/JobUtils.java 135b096
> core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java bc2c1b6
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 390ad3f
> core/src/test/java/org/apache/oozie/test/XFsTestCase.java 18cb742
> core/src/test/java/org/apache/oozie/test/XTestCase.java 1536927
> docs/src/site/twiki/WorkflowFunctionalSpec.twiki f7590d0
>
> Diff: https://reviews.apache.org/r/19929/diff/
>
>
> Testing
> -------
>
> On deployed Hadoop cluster. Two tests were added.
>
>
> Thanks,
>
> Benjamin Zhitomirsky
>
>