[GitHub] [airflow] XD-DENG commented on a change in pull request #12126: Wait option for dagrun operator

[GitBox <gi...@apache.org>]

XD-DENG commented on a change in pull request #12126:
URL: https://github.com/apache/airflow/pull/12126#discussion_r521666703



##########
File path: airflow/operators/dagrun_operator.py
##########
@@ -55,6 +57,14 @@ class TriggerDagRunOperator(BaseOperator):
         When reset_dag_run=False and dag run exists, DagRunAlreadyExists will be raised.
         When reset_dag_run=True and dag run exists, existing dag run will be cleared to rerun.
     :type reset_dag_run: bool
+    :param wait_for_completion: Whether or not wait for dag run completion.

Review comment:
       Would be good to tell users what's the default value here

##########
File path: airflow/operators/dagrun_operator.py
##########
@@ -55,6 +57,14 @@ class TriggerDagRunOperator(BaseOperator):
         When reset_dag_run=False and dag run exists, DagRunAlreadyExists will be raised.
         When reset_dag_run=True and dag run exists, existing dag run will be cleared to rerun.
     :type reset_dag_run: bool
+    :param wait_for_completion: Whether or not wait for dag run completion.
+    :type wait_for_completion: bool
+    :param poke_interval: Poke internal to check dag run status when wait_for_completion=True.

Review comment:
       typo "Poke internal"? Should be "Poke interval"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org