You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/28 09:46:30 UTC
[GitHub] [flink] dawidwys opened a new pull request #14793: [FLINK-21182] Make HeapPriorityQueueStateSnapshot iterable
dawidwys opened a new pull request #14793:
URL: https://github.com/apache/flink/pull/14793
## What is the purpose of the change
In order to implement an iterator for a unified savepoint we need a way
to iterate over all entries in a priority queue snapshot.
## Verifying this change
Added tests in `KeyGroupPartitionerTestBase`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #14793: [FLINK-21182] Make HeapPriorityQueueStateSnapshot iterable
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #14793:
URL: https://github.com/apache/flink/pull/14793#discussion_r566226279
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyGroupPartitioner.java
##########
@@ -125,9 +123,10 @@ public KeyGroupPartitioner(
}
/**
- * Partitions the data into key-groups and returns the result via {@link PartitioningResult}.
+ * Partitions the data into key-groups and returns the result via {@link
+ * PartitioningResultImpl}.
Review comment:
```suggestion
* Partitions the data into key-groups and returns the result as a {@link
* PartitioningResult}.
```
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/KeyGroupPartitionerTestBase.java
##########
@@ -65,7 +77,57 @@ public void testPartitionByKeyGroup() throws IOException {
testPartitionByKeyGroupForSize(10, random);
}
- @SuppressWarnings("unchecked")
+ @Test
Review comment:
I'd probably put these two (three) methods after `testPartitionByKeyGroupForSize()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14793: [FLINK-21182] Make HeapPriorityQueueStateSnapshot iterable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14793:
URL: https://github.com/apache/flink/pull/14793#issuecomment-768936812
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "36e4f49bf7d50a34fc1ac409c15a2d92c6da86c0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12600",
"triggerID" : "36e4f49bf7d50a34fc1ac409c15a2d92c6da86c0",
"triggerType" : "PUSH"
}, {
"hash" : "fdf7c6113aacda8be920ec5d4c83820c2f790c44",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12604",
"triggerID" : "fdf7c6113aacda8be920ec5d4c83820c2f790c44",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 36e4f49bf7d50a34fc1ac409c15a2d92c6da86c0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12600)
* fdf7c6113aacda8be920ec5d4c83820c2f790c44 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12604)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14793: [FLINK-21182] Make HeapPriorityQueueStateSnapshot iterable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14793:
URL: https://github.com/apache/flink/pull/14793#issuecomment-768936812
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "36e4f49bf7d50a34fc1ac409c15a2d92c6da86c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12600",
"triggerID" : "36e4f49bf7d50a34fc1ac409c15a2d92c6da86c0",
"triggerType" : "PUSH"
}, {
"hash" : "fdf7c6113aacda8be920ec5d4c83820c2f790c44",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12604",
"triggerID" : "fdf7c6113aacda8be920ec5d4c83820c2f790c44",
"triggerType" : "PUSH"
}, {
"hash" : "8c008e6a77d225617a407af572a0df8f15c785fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c008e6a77d225617a407af572a0df8f15c785fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fdf7c6113aacda8be920ec5d4c83820c2f790c44 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12604)
* 8c008e6a77d225617a407af572a0df8f15c785fd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14793: [FLINK-21182] Make HeapPriorityQueueStateSnapshot iterable
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14793:
URL: https://github.com/apache/flink/pull/14793#issuecomment-768936812
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "36e4f49bf7d50a34fc1ac409c15a2d92c6da86c0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "36e4f49bf7d50a34fc1ac409c15a2d92c6da86c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 36e4f49bf7d50a34fc1ac409c15a2d92c6da86c0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14793: [FLINK-21182] Make HeapPriorityQueueStateSnapshot iterable
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14793:
URL: https://github.com/apache/flink/pull/14793#issuecomment-768932521
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 36e4f49bf7d50a34fc1ac409c15a2d92c6da86c0 (Thu Jan 28 09:47:58 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys merged pull request #14793: [FLINK-21182] Make HeapPriorityQueueStateSnapshot iterable
Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #14793:
URL: https://github.com/apache/flink/pull/14793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14793: [FLINK-21182] Make HeapPriorityQueueStateSnapshot iterable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14793:
URL: https://github.com/apache/flink/pull/14793#issuecomment-768936812
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "36e4f49bf7d50a34fc1ac409c15a2d92c6da86c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12600",
"triggerID" : "36e4f49bf7d50a34fc1ac409c15a2d92c6da86c0",
"triggerType" : "PUSH"
}, {
"hash" : "fdf7c6113aacda8be920ec5d4c83820c2f790c44",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12604",
"triggerID" : "fdf7c6113aacda8be920ec5d4c83820c2f790c44",
"triggerType" : "PUSH"
}, {
"hash" : "8c008e6a77d225617a407af572a0df8f15c785fd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12617",
"triggerID" : "8c008e6a77d225617a407af572a0df8f15c785fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fdf7c6113aacda8be920ec5d4c83820c2f790c44 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12604)
* 8c008e6a77d225617a407af572a0df8f15c785fd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12617)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14793: [FLINK-21182] Make HeapPriorityQueueStateSnapshot iterable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14793:
URL: https://github.com/apache/flink/pull/14793#issuecomment-768936812
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "36e4f49bf7d50a34fc1ac409c15a2d92c6da86c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12600",
"triggerID" : "36e4f49bf7d50a34fc1ac409c15a2d92c6da86c0",
"triggerType" : "PUSH"
}, {
"hash" : "fdf7c6113aacda8be920ec5d4c83820c2f790c44",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12604",
"triggerID" : "fdf7c6113aacda8be920ec5d4c83820c2f790c44",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fdf7c6113aacda8be920ec5d4c83820c2f790c44 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12604)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14793: [FLINK-21182] Make HeapPriorityQueueStateSnapshot iterable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14793:
URL: https://github.com/apache/flink/pull/14793#issuecomment-768936812
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "36e4f49bf7d50a34fc1ac409c15a2d92c6da86c0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12600",
"triggerID" : "36e4f49bf7d50a34fc1ac409c15a2d92c6da86c0",
"triggerType" : "PUSH"
}, {
"hash" : "fdf7c6113aacda8be920ec5d4c83820c2f790c44",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fdf7c6113aacda8be920ec5d4c83820c2f790c44",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 36e4f49bf7d50a34fc1ac409c15a2d92c6da86c0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12600)
* fdf7c6113aacda8be920ec5d4c83820c2f790c44 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org