You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@geode.apache.org by "Nick Reich (JIRA)" <ji...@apache.org> on 2017/06/28 16:38:00 UTC

[jira] [Resolved] (GEODE-2861) remove deadcode in GemFireCacheImpl and DiskStoreImpl for DiskStoreTaskPool

     [ https://issues.apache.org/jira/browse/GEODE-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nick Reich resolved GEODE-2861.
-------------------------------
    Resolution: Fixed

> remove deadcode in GemFireCacheImpl and DiskStoreImpl for DiskStoreTaskPool
> ---------------------------------------------------------------------------
>
>                 Key: GEODE-2861
>                 URL: https://issues.apache.org/jira/browse/GEODE-2861
>             Project: Geode
>          Issue Type: Improvement
>          Components: persistence
>    Affects Versions: 1.0.0-incubating
>            Reporter: Darrel Schneider
>            Assignee: Nick Reich
>            Priority: Trivial
>              Labels: storage_3
>             Fix For: 1.3.0
>
>
> Both GemFireCacheImpl and DiskStoreImpl have deadcode related to shutting down the DiskStoreTaskPool.
> On DiskStoreImpl see these methods:
>   stopDiskStoreTaskPool
>   shutdownPool
> On GemFireCacheImpl the field diskStoreTaskPool is always null.
> Note that a bug exists in this deadcode that causes it to not call taskCancelled as it iterates over a list of runnables. Since this code is dead it is currently doing no harm but if the code is not removed then make sure and fix this loop.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)