You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/05/13 08:43:12 UTC

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2592: kernel/os: Remove min/max macros for C++

apache-mynewt-bot commented on pull request #2592:
URL: https://github.com/apache/mynewt-core/pull/2592#issuecomment-840414328


   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### kernel/os/include/os/os.h
   <details>
   
   ```diff
   @@ -30,11 +30,11 @@
    #else
    
    #ifndef min
   -#define min(a, b) ((a)<(b)?(a):(b))
   +#define min(a, b) ((a) < (b) ? (a) : (b))
    #endif
    
    #ifndef max
   -#define max(a, b) ((a)>(b)?(a):(b))
   +#define max(a, b) ((a) > (b) ? (a) : (b))
    #endif
    #endif
    
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org