You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/08 16:25:53 UTC

[GitHub] [pulsar] eolivelli opened a new pull request #12673: Pulsar Client: restore SchemaInfo.builder() API

eolivelli opened a new pull request #12673:
URL: https://github.com/apache/pulsar/pull/12673


   Fixes #12670
   
   ### Motivation
   
   In 2.8.0 we dropped SchemaInfo.builder() API and so it is no more possible to create a SchemaInfo instance without using SchemaInfoImpl internal class.
   
   ### Modifications
   
   Restore a Builder, I used Delombok in order to get the same results as before.
   
   Unfortunately SchemaInfo is now an interface, it was a class in 2.7, so we cannot really fix the breaking change at runtime, but at least users will be able to simply rebuild their code.
   
   ### Verifying this change
   
   
   This change is already covered by existing tests
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - The public API: yes
    
   ### Documentation
   
   - [x] `no-need-doc` 
     


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nicoloboschi commented on pull request #12673: Pulsar Client: restore SchemaInfo.builder() API

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #12673:
URL: https://github.com/apache/pulsar/pull/12673#issuecomment-963926552


   the failed test has been fixed here https://github.com/apache/pulsar/pull/12675


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #12673: Pulsar Client: restore SchemaInfo.builder() API

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #12673:
URL: https://github.com/apache/pulsar/pull/12673#issuecomment-964885172


   I have cherry picked this to branch-2.8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nicoloboschi commented on pull request #12673: Pulsar Client: restore SchemaInfo.builder() API

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #12673:
URL: https://github.com/apache/pulsar/pull/12673#issuecomment-963926976


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #12673: Pulsar Client: restore SchemaInfo.builder() API

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #12673:
URL: https://github.com/apache/pulsar/pull/12673#issuecomment-963944596


   @nicoloboschi I have rebased onto latest master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli merged pull request #12673: Pulsar Client: restore SchemaInfo.builder() API

Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #12673:
URL: https://github.com/apache/pulsar/pull/12673


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #12673: Pulsar Client: restore SchemaInfo.builder() API

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #12673:
URL: https://github.com/apache/pulsar/pull/12673#issuecomment-963329000


   @codelipenghui  @merlimat  I would commit this to branch-2.9 before cutting the new RC
   also we should add this to branch-2.8 and get this to next release out of that branch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org