[GitHub] spark pull request #16722: [SPARK-19591][ML][MLlib] Add sample weights to de...

[imatiach-msft <gi...@git.apache.org>]

Github user imatiach-msft commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16722#discussion_r101338639
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/tree/impl/TreeTests.scala ---
    @@ -124,8 +129,8 @@ private[ml] object TreeTests extends SparkFunSuite {
        *       make mistakes such as creating loops of Nodes.
        */
       private def checkEqual(a: Node, b: Node): Unit = {
    -    assert(a.prediction === b.prediction)
    -    assert(a.impurity === b.impurity)
    +    assert(a.prediction ~== b.prediction absTol 1e-8)
    +    assert(a.impurity ~== b.impurity absTol 1e-8)
    --- End diff --
    
    it's strange that we are using different tolerances everywhere as opposed to a few specific ones (say 1e-7 for absolute and 1e-3 for relative).  But since they are different everywhere, you are right, it would be overengineering, so I think it's ok to leave as is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org