You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/06/14 22:05:32 UTC

[GitHub] [trafficcontrol] rob05c opened a new pull request #5935: Add atscfg storage.config generation tests

rob05c opened a new pull request #5935:
URL: https://github.com/apache/trafficcontrol/pull/5935


   Also fixes a poorly behaving failsafe. If a drive prefix parameter
   exists but no drive letters, it should warn but not insert it.
   It was inserting a malformed prefix with no letter, e.g. '/dev/sd'.
   This fixes it to not insert, in the event someone's Parameters are
   malformed and have a prefix but no letters.
   
   Is tests.
   No docs, no interface change.
   No changelog, no interface change and not a bug.
   
   - [x] This PR is not related to any other Issue
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops ORT
   
   ## What is the best way to verify this PR?
   Run lib/go-atscfg unit tests.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   Not a bug fix.
   
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   ## Additional Information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] dneuman64 merged pull request #5935: Add atscfg storage.config generation tests

Posted by GitBox <gi...@apache.org>.
dneuman64 merged pull request #5935:
URL: https://github.com/apache/trafficcontrol/pull/5935


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org