You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/05 17:47:41 UTC

[GitHub] [airflow] ashb commented on a change in pull request #7363: [AIRFLOW-6730] Use total_seconds instead of seconds

ashb commented on a change in pull request #7363: [AIRFLOW-6730] Use total_seconds instead of seconds
URL: https://github.com/apache/airflow/pull/7363#discussion_r375409336
 
 

 ##########
 File path: airflow/providers/google/cloud/operators/postgres_to_gcs.py
 ##########
 @@ -94,7 +94,7 @@ def convert_type(self, value, schema_type):
             return datetime.timedelta(
                 hours=formated_time.tm_hour,
                 minutes=formated_time.tm_min,
-                seconds=formated_time.tm_sec).seconds
+                seconds=formated_time.tm_sec).total_seconds()
 
 Review comment:
   This one is I think wrong.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services