[jira] Commented: (DERBY-2296) getProperties method deprecated on ClientDataSource

["Daniel John Debrunner (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-2296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488764 ] 

Daniel John Debrunner commented on DERBY-2296:
----------------------------------------------

I don't think this patch works as expected for a couple of reasons:

1) If setConnectionAttributes() is called after setCreateDatabase or setShutdownDatabase then the create/shutdown state will be lost.

2) If the order is reversed to 1) then getConnectionAttributes() will not return the same value as the one set by the application.

3) Repeated calls to setCreateDatabase or setShutdownDatabase will continually add create=true/shutdown=true to connection attributes.


why are the fields public?

> getProperties method deprecated on ClientDataSource
> ---------------------------------------------------
>
>                 Key: DERBY-2296
>                 URL: https://issues.apache.org/jira/browse/DERBY-2296
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client
>    Affects Versions: 10.2.1.6, 10.2.2.0
>         Environment: All
>            Reporter: Matt Hogstrom
>             Fix For: 10.2.2.1
>
>         Attachments: DERBY-2296_20070412.diff
>
>
> Not sure exactly where this was deprecated but on Client DataSources it appears that the getProperties method was made private.  In Geronimo we were using this to inquire and set whether a create=true was set for a database.  
> We are moving from 10.1.3.1 to 10.2.1.6 (or perhaps 10.2.2.0) for our next version which we are targetting for April of this year.
> Is it possible to add the following methods on the ClientDataSource:
>  setCreateDatabase (String)
>  getCreateDatabase()
>  setShutdownDatabase (String)
>  getShutdownDatabase()
> as they are on the EmbeddedDataSource?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.