You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by hn5092 <gi...@git.apache.org> on 2018/08/21 10:27:26 UTC
[GitHub] spark pull request #22169: Kyspark 2.1.1 r3
GitHub user hn5092 opened a pull request:
https://github.com/apache/spark/pull/22169
Kyspark 2.1.1 r3
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hn5092/spark kyspark-2.1.1-r3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22169.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22169
----
commit ca25b1e51f036fb837e3fe8218cb04d7360e049d
Author: Kousuke Saruta <sa...@...>
Date: 2016-12-24T13:02:58Z
[SPARK-18837][WEBUI] Very long stage descriptions do not wrap in the UI
## What changes were proposed in this pull request?
This issue was reported by wangyum.
In the AllJobsPage, JobPage and StagePage, the description length was limited before like as follows.
But recently, the limitation seems to have been accidentally removed.
The cause is that some tables are no longer `sortable` class although they were, and `sortable` class does not only mark tables as sortable but also limited the width of their child `td` elements.
The reason why now some tables are not `sortable` class is because another sortable mechanism was introduced by #13620 and #13708 with pagination feature.
To fix this issue, I've introduced new class `table-cell-width-limited` which limits the description cell width and the description is like what it was.
<img width="1260" alt="2016-12-20 1 00 34" src="https://cloud.githubusercontent.com/assets/4736016/21320478/89141c7a-c654-11e6-8494-f8f91325980b.png">
## How was this patch tested?
Tested manually with my browser.
Author: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Closes #16338 from sarutak/SPARK-18837.
(cherry picked from commit f2ceb2abe9357942a51bd643683850efd1fc9df7)
Signed-off-by: Sean Owen <so...@cloudera.com>
commit ac7107fe70fcd0b584001c10dd624a4d8757109c
Author: Carson Wang <ca...@...>
Date: 2016-12-28T12:12:44Z
[MINOR][DOC] Fix doc of ForeachWriter to use writeStream
## What changes were proposed in this pull request?
Fix the document of `ForeachWriter` to use `writeStream` instead of `write` for a streaming dataset.
## How was this patch tested?
Docs only.
Author: Carson Wang <ca...@intel.com>
Closes #16419 from carsonwang/FixDoc.
(cherry picked from commit 2a5f52a7146abc05bf70e65eb2267cd869ac4789)
Signed-off-by: Sean Owen <so...@cloudera.com>
commit 7197a7bc7061e2908b6430f494dba378378d5d02
Author: Sean Owen <so...@...>
Date: 2016-12-28T12:17:33Z
[SPARK-18993][BUILD] Unable to build/compile Spark in IntelliJ due to missing Scala deps in spark-tags
## What changes were proposed in this pull request?
This adds back a direct dependency on Scala library classes from spark-tags because its Scala annotations need them.
## How was this patch tested?
Existing tests
Author: Sean Owen <so...@cloudera.com>
Closes #16418 from srowen/SPARK-18993.
(cherry picked from commit d7bce3bd31ec193274718042dc017706989d7563)
Signed-off-by: Sean Owen <so...@cloudera.com>
commit 80d583bd09de54890cddfcc0c6fd807d7200ea75
Author: Tathagata Das <ta...@...>
Date: 2016-12-28T20:11:25Z
[SPARK-18669][SS][DOCS] Update Apache docs for Structured Streaming regarding watermarking and status
## What changes were proposed in this pull request?
- Extended the Window operation section with code snippet and explanation of watermarking
- Extended the Output Mode section with a table showing the compatibility between query type and output mode
- Rewrote the Monitoring section with updated jsons generated by StreamingQuery.progress/status
- Updated API changes in the StreamingQueryListener example
TODO
- [x] Figure showing the watermarking
## How was this patch tested?
N/A
## Screenshots
### Section: Windowed Aggregation with Event Time
<img width="927" alt="screen shot 2016-12-15 at 3 33 10 pm" src="https://cloud.githubusercontent.com/assets/663212/21246197/0e02cb1a-c2dc-11e6-8816-0cd28d8201d7.png">
<img width="929" alt="screen shot 2016-12-15 at 3 33 46 pm" src="https://cloud.githubusercontent.com/assets/663212/21246202/1652cefa-c2dc-11e6-8c64-3c05977fb3fc.png">
----------------------------
### Section: Output Modes
----------------------------
### Section: Monitoring
Author: Tathagata Das <ta...@gmail.com>
Closes #16294 from tdas/SPARK-18669.
(cherry picked from commit 092c6725bf039bf33299b53791e1958c4ea3f6aa)
Signed-off-by: Shixiong Zhu <sh...@databricks.com>
commit 47ab4afed69bb019b4e0f85e26e52dc5cee338df
Author: adesharatushar <tu...@...>
Date: 2016-12-29T22:03:34Z
[SPARK-19003][DOCS] Add Java example in Spark Streaming Guide, section Design Patterns for using foreachRDD
## What changes were proposed in this pull request?
Added missing Java example under section "Design Patterns for using foreachRDD". Now this section has examples in all 3 languages, improving consistency of documentation.
## How was this patch tested?
Manual.
Generated docs using command "SKIP_API=1 jekyll build" and verified generated HTML page manually.
The syntax of example has been tested for correctness using sample code on Java1.7 and Spark 2.2.0-SNAPSHOT.
Author: adesharatushar <tu...@persistent.com>
Closes #16408 from adesharatushar/streaming-doc-fix.
(cherry picked from commit dba81e1dcdea1e8bd196c88d4810f9a04312acbf)
Signed-off-by: Sean Owen <so...@cloudera.com>
commit 20ae11722d82cf3cdaa8c4023e37c1416664917d
Author: Cheng Lian <li...@...>
Date: 2016-12-30T22:46:30Z
[SPARK-19016][SQL][DOC] Document scalable partition handling
This PR documents the scalable partition handling feature in the body of the programming guide.
Before this PR, we only mention it in the migration guide. It's not super clear that external datasource tables require an extra `MSCK REPAIR TABLE` command is to have per-partition information persisted since 2.1.
N/A.
Author: Cheng Lian <li...@databricks.com>
Closes #16424 from liancheng/scalable-partition-handling-doc.
(cherry picked from commit 871f6114ac0075a1b45eda8701113fa20d647de9)
Signed-off-by: Cheng Lian <li...@databricks.com>
commit 3483defeb82b8333da238b21229e6a8c82820d48
Author: Shixiong Zhu <sh...@...>
Date: 2017-01-01T21:25:44Z
[SPARK-19050][SS][TESTS] Fix EventTimeWatermarkSuite 'delay in months and years handled correctly'
## What changes were proposed in this pull request?
`monthsSinceEpoch` in this test is like `math.floor(num)`, so `monthDiff` has two possible values.
## How was this patch tested?
Jenkins.
Author: Shixiong Zhu <sh...@databricks.com>
Closes #16449 from zsxwing/watermark-test-hotfix.
(cherry picked from commit 2394047370d2d93bd8bc57b996fee47465c470af)
Signed-off-by: Shixiong Zhu <sh...@databricks.com>
commit 63857c8d30ceef9bf998659fc12ea8872c0f36ea
Author: Liang-Chi Hsieh <vi...@...>
Date: 2017-01-02T14:41:57Z
[MINOR][DOC] Minor doc change for YARN credential providers
## What changes were proposed in this pull request?
The configuration `spark.yarn.security.tokens.{service}.enabled` is deprecated. Now we should use `spark.yarn.security.credentials.{service}.enabled`. Some places in the doc is not updated yet.
## How was this patch tested?
N/A. Just doc change.
Please review http://spark.apache.org/contributing.html before opening a pull request.
Author: Liang-Chi Hsieh <vi...@gmail.com>
Closes #16444 from viirya/minor-credential-provider-doc.
(cherry picked from commit 0ac2f1e71f62ec925ed0e19c4654759d155efc35)
Signed-off-by: Sean Owen <so...@cloudera.com>
commit 517f39833cf789b536defe5ba4b010828d24831f
Author: genmao.ygm <ge...@...>
Date: 2016-11-15T18:32:43Z
[SPARK-18379][SQL] Make the parallelism of parallelPartitionDiscovery configurable.
## What changes were proposed in this pull request?
The largest parallelism in PartitioningAwareFileIndex #listLeafFilesInParallel() is 10000 in hard code. We may need to make this number configurable. And in PR, I reduce it to 100.
## How was this patch tested?
Existing ut.
Author: genmao.ygm <ge...@genmaoygmdeMacBook-Air.local>
Author: dylon <hu...@gmail.com>
Closes #15829 from uncleGen/SPARK-18379.
(cherry picked from commit 745ab8bc50da89c42b297de9dcb833e5f2074481)
Signed-off-by: Sean Owen <so...@cloudera.com>
commit d489e1dc7ecf7cf081141d3f45f86c39fc3db1fe
Author: Liwei Lin <lw...@...>
Date: 2017-01-02T14:40:06Z
[SPARK-19041][SS] Fix code snippet compilation issues in Structured Streaming Programming Guide
## What changes were proposed in this pull request?
Currently some code snippets in the programming guide just do not compile. We should fix them.
## How was this patch tested?
```
SKIP_API=1 jekyll build
```
## Screenshot from part of the change:
Author: Liwei Lin <lw...@gmail.com>
Closes #16442 from lw-lin/ss-pro-guide-.
commit 94272a9600405442bfe485b17e55a84b85c25da3
Author: gatorsmile <ga...@...>
Date: 2016-12-31T11:40:28Z
[SPARK-19028][SQL] Fixed non-thread-safe functions used in SessionCatalog
### What changes were proposed in this pull request?
Fixed non-thread-safe functions used in SessionCatalog:
- refreshTable
- lookupRelation
### How was this patch tested?
N/A
Author: gatorsmile <ga...@gmail.com>
Closes #16437 from gatorsmile/addSyncToLookUpTable.
(cherry picked from commit 35e974076dcbc5afde8d4259ce88cb5f29d94920)
Signed-off-by: Wenchen Fan <we...@databricks.com>
commit 776255065c13df7b4505c225546b4b66cd929c76
Author: gatorsmile <ga...@...>
Date: 2017-01-03T19:43:47Z
[SPARK-19048][SQL] Delete Partition Location when Dropping Managed Partitioned Tables in InMemoryCatalog
### What changes were proposed in this pull request?
The data in the managed table should be deleted after table is dropped. However, if the partition location is not under the location of the partitioned table, it is not deleted as expected. Users can specify any location for the partition when they adding a partition.
This PR is to delete partition location when dropping managed partitioned tables stored in `InMemoryCatalog`.
### How was this patch tested?
Added test cases for both HiveExternalCatalog and InMemoryCatalog
Author: gatorsmile <ga...@gmail.com>
Closes #16448 from gatorsmile/unsetSerdeProp.
(cherry picked from commit b67b35f76b684c5176dc683e7491fd01b43f4467)
Signed-off-by: gatorsmile <ga...@gmail.com>
commit 1ecf1a953ee0f0f0925bb8a3df54d3e762116f1a
Author: Dongjoon Hyun <do...@...>
Date: 2017-01-04T17:56:11Z
[SPARK-18877][SQL][BACKPORT-2.1] CSVInferSchema.inferField` on DecimalType should find a common type with `typeSoFar`
## What changes were proposed in this pull request?
CSV type inferencing causes `IllegalArgumentException` on decimal numbers with heterogeneous precisions and scales because the current logic uses the last decimal type in a **partition**. Specifically, `inferRowType`, the **seqOp** of **aggregate**, returns the last decimal type. This PR fixes it to use `findTightestCommonType`.
**decimal.csv**
```
9.03E+12
1.19E+11
```
**BEFORE**
```scala
scala> spark.read.format("csv").option("inferSchema", true).load("decimal.csv").printSchema
root
|-- _c0: decimal(3,-9) (nullable = true)
scala> spark.read.format("csv").option("inferSchema", true).load("decimal.csv").show
16/12/16 14:32:49 ERROR Executor: Exception in task 0.0 in stage 4.0 (TID 4)
java.lang.IllegalArgumentException: requirement failed: Decimal precision 4 exceeds max precision 3
```
**AFTER**
```scala
scala> spark.read.format("csv").option("inferSchema", true).load("decimal.csv").printSchema
root
|-- _c0: decimal(4,-9) (nullable = true)
scala> spark.read.format("csv").option("inferSchema", true).load("decimal.csv").show
+---------+
| _c0|
+---------+
|9.030E+12|
| 1.19E+11|
+---------+
```
## How was this patch tested?
Pass the newly add test case.
Author: Dongjoon Hyun <do...@apache.org>
Closes #16463 from dongjoon-hyun/SPARK-18877-BACKPORT-21.
commit 4ca1788805e4a0131ba8f0ccb7499ee0e0242837
Author: jerryshao <ss...@...>
Date: 2017-01-06T16:07:54Z
[SPARK-19033][CORE] Add admin acls for history server
## What changes were proposed in this pull request?
Current HistoryServer's ACLs is derived from application event-log, which means the newly changed ACLs cannot be applied to the old data, this will become a problem where newly added admin cannot access the old application history UI, only the new application can be affected.
So here propose to add admin ACLs for history server, any configured user/group could have the view access to all the applications, while the view ACLs derived from application run-time still take effect.
## How was this patch tested?
Unit test added.
Author: jerryshao <ss...@hortonworks.com>
Closes #16470 from jerryshao/SPARK-19033.
(cherry picked from commit 4a4c3dc9ca10e52f7981b225ec44e97247986905)
Signed-off-by: Tom Graves <tg...@yahoo-inc.com>
commit ce9bfe6db63582d632f7d57cbf37ee7b29135198
Author: zuotingbing <zu...@...>
Date: 2017-01-06T17:57:49Z
[SPARK-19083] sbin/start-history-server.sh script use of $@ without quotes
JIRA Issue: https://issues.apache.org/jira/browse/SPARK-19083#
sbin/start-history-server.sh script use of $ without quotes, this will affect the length of args which used in HistoryServerArguments::parse(args: List[String])
Author: zuotingbing <zu...@zte.com.cn>
Closes #16484 from zuotingbing/sh.
(cherry picked from commit a9a137377e4cf293325ccd7368698f20b5d6b98a)
Signed-off-by: Marcelo Vanzin <va...@cloudera.com>
commit ee735a8a85d7f015188f7cb31975f60cc969e453
Author: Tathagata Das <ta...@...>
Date: 2017-01-06T19:29:01Z
[SPARK-19074][SS][DOCS] Updated Structured Streaming Programming Guide for update mode and source/sink options
## What changes were proposed in this pull request?
Updates
- Updated Late Data Handling section by adding a figure for Update Mode. Its more intuitive to explain late data handling with Update Mode, so I added the new figure before the Append Mode figure.
- Updated Output Modes section with Update mode
- Added options for all the sources and sinks
---------------------------
---------------------------
---------------------------
---------------------------
<img width="931" alt="screen shot 2017-01-03 at 6 09 11 pm" src="https://cloud.githubusercontent.com/assets/663212/21629740/d21c9bb8-d1df-11e6-915b-488a59589fa6.png">
<img width="933" alt="screen shot 2017-01-03 at 6 10 00 pm" src="https://cloud.githubusercontent.com/assets/663212/21629749/e22bdabe-d1df-11e6-86d3-7e51d2f28dbc.png">
---------------------------
---------------------------
Author: Tathagata Das <ta...@gmail.com>
Closes #16468 from tdas/SPARK-19074.
(cherry picked from commit b59cddaba01cbdf50dbe8fe7ef7b9913bad9552d)
Signed-off-by: Tathagata Das <ta...@gmail.com>
commit 86b66216de411f8cbc79ede62b353f7cbb550903
Author: wm624@hotmail.com <wm...@...>
Date: 2017-01-07T19:07:49Z
[SPARK-19110][ML][MLLIB] DistributedLDAModel returns different logPrior for original and loaded model
## What changes were proposed in this pull request?
While adding DistributedLDAModel training summary for SparkR, I found that the logPrior for original and loaded model is different.
For example, in the test("read/write DistributedLDAModel"), I add the test:
val logPrior = model.asInstanceOf[DistributedLDAModel].logPrior
val logPrior2 = model2.asInstanceOf[DistributedLDAModel].logPrior
assert(logPrior === logPrior2)
The test fails:
-4.394180878889078 did not equal -4.294290536919573
The reason is that `graph.vertices.aggregate(0.0)(seqOp, _ + _)` only returns the value of a single vertex instead of the aggregation of all vertices. Therefore, when the loaded model does the aggregation in a different order, it returns different `logPrior`.
Please refer to #16464 for details.
## How was this patch tested?
Add a new unit test for testing logPrior.
Author: wm624@hotmail.com <wm...@hotmail.com>
Closes #16491 from wangmiao1981/ldabug.
(cherry picked from commit 036b50347c56a3541c526b1270093163b9b79e45)
Signed-off-by: Joseph K. Bradley <jo...@databricks.com>
commit c95b58557dec2f4708d5efd9314edd80e0975fc8
Author: Sean Owen <so...@...>
Date: 2017-01-07T19:15:51Z
[SPARK-19106][DOCS] Styling for the configuration docs is broken
configuration.html section headings were not specified correctly in markdown and weren't rendering, being recognized correctly. Removed extra p tags and pulled level 4 titles up to level 3, since level 3 had been skipped. This improves the TOC.
Doc build, manual check.
Author: Sean Owen <so...@cloudera.com>
Closes #16490 from srowen/SPARK-19106.
(cherry picked from commit 54138f6e89abfc17101b4f2812715784a2b98331)
Signed-off-by: Sean Owen <so...@cloudera.com>
commit ecc16220d2d9eace81de44c4b0aff1c364a35e3f
Author: Dongjoon Hyun <do...@...>
Date: 2017-01-08T02:55:01Z
[SPARK-18941][SQL][DOC] Add a new behavior document on `CREATE/DROP TABLE` with `LOCATION`
## What changes were proposed in this pull request?
This PR adds a new behavior change description on `CREATE TABLE ... LOCATION` at `sql-programming-guide.md` clearly under `Upgrading From Spark SQL 1.6 to 2.0`. This change is introduced at Apache Spark 2.0.0 as [SPARK-15276](https://issues.apache.org/jira/browse/SPARK-15276).
## How was this patch tested?
```
SKIP_API=1 jekyll build
```
**Newly Added Description**
<img width="913" alt="new" src="https://cloud.githubusercontent.com/assets/9700541/21743606/7efe2b12-d4ba-11e6-8a0d-551222718ea2.png">
Author: Dongjoon Hyun <do...@apache.org>
Closes #16400 from dongjoon-hyun/SPARK-18941.
(cherry picked from commit 923e594844a7ad406195b91877f0fb374d5a454b)
Signed-off-by: gatorsmile <ga...@gmail.com>
commit 8690d4bd150579e546aec7866b16a77bad1017f5
Author: anabranch <wa...@...>
Date: 2017-01-09T01:53:53Z
[SPARK-19127][DOCS] Update Rank Function Documentation
## What changes were proposed in this pull request?
- [X] Fix inconsistencies in function reference for dense rank and dense
- [X] Make all languages equivalent in their reference to `dense_rank` and `rank`.
## How was this patch tested?
N/A for docs.
Please review http://spark.apache.org/contributing.html before opening a pull request.
Author: anabranch <wa...@gmail.com>
Closes #16505 from anabranch/SPARK-19127.
(cherry picked from commit 1f6ded6455d07ec8828fc9662ddffe55cbba4238)
Signed-off-by: Reynold Xin <rx...@databricks.com>
commit 8779e6a4685f50a7062842f0d5a606c3a3b092d5
Author: anabranch <wa...@...>
Date: 2017-01-09T04:37:46Z
[SPARK-19126][DOCS] Update Join Documentation Across Languages
## What changes were proposed in this pull request?
- [X] Make sure all join types are clearly mentioned
- [X] Make join labeling/style consistent
- [X] Make join label ordering docs the same
- [X] Improve join documentation according to above for Scala
- [X] Improve join documentation according to above for Python
- [X] Improve join documentation according to above for R
## How was this patch tested?
No tests b/c docs.
Please review http://spark.apache.org/contributing.html before opening a pull request.
Author: anabranch <wa...@gmail.com>
Closes #16504 from anabranch/SPARK-19126.
(cherry picked from commit 19d9d4c855eab8f647a5ec66b079172de81221d0)
Signed-off-by: Felix Cheung <fe...@apache.org>
commit 80a3e13e58036c2461c4b721cb298ffd13b7823f
Author: Felix Cheung <fe...@...>
Date: 2017-01-09T04:42:18Z
[SPARK-18903][SPARKR][BACKPORT-2.1] Add API to get SparkUI URL
## What changes were proposed in this pull request?
backport to 2.1
Author: Felix Cheung <fe...@hotmail.com>
Closes #16507 from felixcheung/portsparkuir21.
commit 3b6ac323b16f8f6d79ee7bac6e7a57f841897d96
Author: Burak Yavuz <br...@...>
Date: 2017-01-09T23:17:59Z
[SPARK-18952][BACKPORT] Regex strings not properly escaped in codegen for aggregations
## What changes were proposed in this pull request?
Backport for #16361 to 2.1 branch.
## How was this patch tested?
Unit tests
Author: Burak Yavuz <br...@gmail.com>
Closes #16518 from brkyvz/reg-break-2.1.
commit 65c866ef9e0b325998ce26f698e409c00a3f11e7
Author: Liwei Lin <lw...@...>
Date: 2017-01-10T11:35:46Z
[SPARK-16845][SQL] `GeneratedClass$SpecificOrdering` grows beyond 64 KB
## What changes were proposed in this pull request?
Prior to this patch, we'll generate `compare(...)` for `GeneratedClass$SpecificOrdering` like below, leading to Janino exceptions saying the code grows beyond 64 KB.
``` scala
/* 005 */ class SpecificOrdering extends o.a.s.sql.catalyst.expressions.codegen.BaseOrdering {
/* ..... */ ...
/* 10969 */ private int compare(InternalRow a, InternalRow b) {
/* 10970 */ InternalRow i = null; // Holds current row being evaluated.
/* 10971 */
/* 1.... */ code for comparing field0
/* 1.... */ code for comparing field1
/* 1.... */ ...
/* 1.... */ code for comparing field449
/* 15012 */
/* 15013 */ return 0;
/* 15014 */ }
/* 15015 */ }
```
This patch would break `compare(...)` into smaller `compare_xxx(...)` methods when necessary; then we'll get generated `compare(...)` like:
``` scala
/* 001 */ public SpecificOrdering generate(Object[] references) {
/* 002 */ return new SpecificOrdering(references);
/* 003 */ }
/* 004 */
/* 005 */ class SpecificOrdering extends o.a.s.sql.catalyst.expressions.codegen.BaseOrdering {
/* 006 */
/* 007 */ ...
/* 1.... */
/* 11290 */ private int compare_0(InternalRow a, InternalRow b) {
/* 11291 */ InternalRow i = null; // Holds current row being evaluated.
/* 11292 */
/* 11293 */ i = a;
/* 11294 */ boolean isNullA;
/* 11295 */ UTF8String primitiveA;
/* 11296 */ {
/* 11297 */
/* 11298 */ Object obj = ((Expression) references[0]).eval(null);
/* 11299 */ UTF8String value = (UTF8String) obj;
/* 11300 */ isNullA = false;
/* 11301 */ primitiveA = value;
/* 11302 */ }
/* 11303 */ i = b;
/* 11304 */ boolean isNullB;
/* 11305 */ UTF8String primitiveB;
/* 11306 */ {
/* 11307 */
/* 11308 */ Object obj = ((Expression) references[0]).eval(null);
/* 11309 */ UTF8String value = (UTF8String) obj;
/* 11310 */ isNullB = false;
/* 11311 */ primitiveB = value;
/* 11312 */ }
/* 11313 */ if (isNullA && isNullB) {
/* 11314 */ // Nothing
/* 11315 */ } else if (isNullA) {
/* 11316 */ return -1;
/* 11317 */ } else if (isNullB) {
/* 11318 */ return 1;
/* 11319 */ } else {
/* 11320 */ int comp = primitiveA.compare(primitiveB);
/* 11321 */ if (comp != 0) {
/* 11322 */ return comp;
/* 11323 */ }
/* 11324 */ }
/* 11325 */
/* 11326 */
/* 11327 */ i = a;
/* 11328 */ boolean isNullA1;
/* 11329 */ UTF8String primitiveA1;
/* 11330 */ {
/* 11331 */
/* 11332 */ Object obj1 = ((Expression) references[1]).eval(null);
/* 11333 */ UTF8String value1 = (UTF8String) obj1;
/* 11334 */ isNullA1 = false;
/* 11335 */ primitiveA1 = value1;
/* 11336 */ }
/* 11337 */ i = b;
/* 11338 */ boolean isNullB1;
/* 11339 */ UTF8String primitiveB1;
/* 11340 */ {
/* 11341 */
/* 11342 */ Object obj1 = ((Expression) references[1]).eval(null);
/* 11343 */ UTF8String value1 = (UTF8String) obj1;
/* 11344 */ isNullB1 = false;
/* 11345 */ primitiveB1 = value1;
/* 11346 */ }
/* 11347 */ if (isNullA1 && isNullB1) {
/* 11348 */ // Nothing
/* 11349 */ } else if (isNullA1) {
/* 11350 */ return -1;
/* 11351 */ } else if (isNullB1) {
/* 11352 */ return 1;
/* 11353 */ } else {
/* 11354 */ int comp = primitiveA1.compare(primitiveB1);
/* 11355 */ if (comp != 0) {
/* 11356 */ return comp;
/* 11357 */ }
/* 11358 */ }
/* 1.... */
/* 1.... */ ...
/* 1.... */
/* 12652 */ return 0;
/* 12653 */ }
/* 1.... */
/* 1.... */ ...
/* 15387 */
/* 15388 */ public int compare(InternalRow a, InternalRow b) {
/* 15389 */
/* 15390 */ int comp_0 = compare_0(a, b);
/* 15391 */ if (comp_0 != 0) {
/* 15392 */ return comp_0;
/* 15393 */ }
/* 15394 */
/* 15395 */ int comp_1 = compare_1(a, b);
/* 15396 */ if (comp_1 != 0) {
/* 15397 */ return comp_1;
/* 15398 */ }
/* 1.... */
/* 1.... */ ...
/* 1.... */
/* 15450 */ return 0;
/* 15451 */ }
/* 15452 */ }
```
## How was this patch tested?
- a new added test case which
- would fail prior to this patch
- would pass with this patch
- ordering correctness should already be covered by existing tests like those in `OrderingSuite`
## Acknowledgement
A major part of this PR - the refactoring work of `splitExpression()` - has been done by ueshin.
Author: Liwei Lin <lw...@gmail.com>
Author: Takuya UESHIN <ue...@happy-camper.st>
Author: Takuya Ueshin <ue...@happy-camper.st>
Closes #15480 from lw-lin/spec-ordering-64k-.
(cherry picked from commit acfc5f354332107cc744fb636e3730f6fc48b2fe)
Signed-off-by: Wenchen Fan <we...@databricks.com>
commit 69d1c4c5c9510ccf05a0f05592201d5b756425f9
Author: Dongjoon Hyun <do...@...>
Date: 2017-01-10T18:49:44Z
[SPARK-19137][SQL] Fix `withSQLConf` to reset `OptionalConfigEntry` correctly
## What changes were proposed in this pull request?
`DataStreamReaderWriterSuite` makes test files in source folder like the followings. Interestingly, the root cause is `withSQLConf` fails to reset `OptionalConfigEntry` correctly. In other words, it resets the config into `Some(undefined)`.
```bash
$ git status
Untracked files:
(use "git add <file>..." to include in what will be committed)
sql/core/%253Cundefined%253E/
sql/core/%3Cundefined%3E/
```
## How was this patch tested?
Manual.
```
build/sbt "project sql" test
git status
```
Author: Dongjoon Hyun <do...@apache.org>
Closes #16522 from dongjoon-hyun/SPARK-19137.
(cherry picked from commit d5b1dc934a2482886c2c095de90e4c6a49ec42bd)
Signed-off-by: Shixiong Zhu <sh...@databricks.com>
commit e0af4b7263a49419fefc36a6dedf2183c1157912
Author: Shixiong Zhu <sh...@...>
Date: 2017-01-10T14:24:45Z
[SPARK-19113][SS][TESTS] Set UncaughtExceptionHandler in onQueryStarted to ensure catching fatal errors during query initialization
## What changes were proposed in this pull request?
StreamTest sets `UncaughtExceptionHandler` after starting the query now. It may not be able to catch fatal errors during query initialization. This PR uses `onQueryStarted` callback to fix it.
## How was this patch tested?
Jenkins
Author: Shixiong Zhu <sh...@databricks.com>
Closes #16492 from zsxwing/SPARK-19113.
commit 81c9430900f44f0602c7d32b298b90afa7450113
Author: Sean Owen <so...@...>
Date: 2017-01-10T20:40:21Z
[SPARK-18997][CORE] Recommended upgrade libthrift to 0.9.3
## What changes were proposed in this pull request?
Updates to libthrift 0.9.3 to address a CVE.
## How was this patch tested?
Existing tests.
Author: Sean Owen <so...@cloudera.com>
Closes #16530 from srowen/SPARK-18997.
(cherry picked from commit 856bae6af64982ae0221948c58ff564887e54a70)
Signed-off-by: Marcelo Vanzin <va...@cloudera.com>
commit 230607d62493c36b214c01a70aa9b0dbb3a9ad4d
Author: Shixiong Zhu <sh...@...>
Date: 2017-01-11T01:58:11Z
[SPARK-19140][SS] Allow update mode for non-aggregation streaming queries
## What changes were proposed in this pull request?
This PR allow update mode for non-aggregation streaming queries. It will be same as the append mode if a query has no aggregations.
## How was this patch tested?
Jenkins
Author: Shixiong Zhu <sh...@databricks.com>
Closes #16520 from zsxwing/update-without-agg.
(cherry picked from commit bc6c56e940fe93591a1e5ba45751f1b243b57e28)
Signed-off-by: Shixiong Zhu <sh...@databricks.com>
commit 1022049c78e55914c54dff6d5206ad56dba7eef4
Author: Felix Cheung <fe...@...>
Date: 2017-01-11T05:22:16Z
[SPARK-19133][SPARKR][ML][BACKPORT-2.1] fix glm for Gamma, clarify glm family supported
## What changes were proposed in this pull request?
backporting to 2.1, 2.0 and 1.6
## How was this patch tested?
unit tests
Author: Felix Cheung <fe...@hotmail.com>
Closes #16532 from felixcheung/rgammabackport.
commit 82fcc133040cb5ef32f10df73fcb9fd8914aa9c1
Author: Felix Cheung <fe...@...>
Date: 2017-01-11T16:29:09Z
[SPARK-19130][SPARKR] Support setting literal value as column implicitly
## What changes were proposed in this pull request?
```
df$foo <- 1
```
instead of
```
df$foo <- lit(1)
```
## How was this patch tested?
unit tests
Author: Felix Cheung <fe...@hotmail.com>
Closes #16510 from felixcheung/rlitcol.
(cherry picked from commit d749c06677c2fd383733337f1c00f542da122b8d)
Signed-off-by: Shivaram Venkataraman <sh...@cs.berkeley.edu>
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22169: Kyspark 2.1.1 r3
Posted by hn5092 <gi...@git.apache.org>.
Github user hn5092 closed the pull request at:
https://github.com/apache/spark/pull/22169
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org