You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jackye1995 (via GitHub)" <gi...@apache.org> on 2023/03/23 16:35:00 UTC
[GitHub] [iceberg] jackye1995 opened a new issue, #7186: Enforce variable order in checkstyle
jackye1995 opened a new issue, #7186:
URL: https://github.com/apache/iceberg/issues/7186
### Feature Request / Improvement
Not sure if possible, but ideally we want checkstyle to enforce all variables in all classes in the order of
- logger
- `public static final`
- `private static final`
- `private static`
- `private final`
- `private`
- `private transient`
- `private transient volatile`
Any thoughts? @nastra @ajantha-bhat
### Query engine
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Enforce variable order in checkstyle [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #7186:
URL: https://github.com/apache/iceberg/issues/7186#issuecomment-1776250781
This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on issue #7186: Enforce variable order in checkstyle
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on issue #7186:
URL: https://github.com/apache/iceberg/issues/7186#issuecomment-1482362413
I'm sure this can be enforced but I don't think it's a good idea to do that if we don't have tools that would automatically apply those variable orderings.
Then you basically have the same problem that we had pre-spotless, where checkstyle would enforce something but you would have to manually go and apply it.
That being said, I generally like the idea of consistent formatting & ordering across the codebase, but I'm not sure this can be easily achieved automatically when formatting code via CMD line / IDE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Enforce variable order in checkstyle [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #7186: Enforce variable order in checkstyle
URL: https://github.com/apache/iceberg/issues/7186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on issue #7186: Enforce variable order in checkstyle
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on issue #7186:
URL: https://github.com/apache/iceberg/issues/7186#issuecomment-1483156870
> if we don't have tools that would automatically apply those variable orderings.
I think the argument against that is, even today there are still checkstyle failures that cannot be fixed by spotless. I encountered it a few times but sorry I cannot recall what were the checkstyle errors.
At least my goal is to remove as much need for human-linting as possible. This is one case, there are also cases about styles of newlines that we sometimes still human-lint. If adding some checkstyle rules means we no longer need to check those styles and the developer him/herself has to fix some checkstyle error I am actually fine with that. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar commented on issue #7186: Enforce variable order in checkstyle
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on issue #7186:
URL: https://github.com/apache/iceberg/issues/7186#issuecomment-1481731059
I think it should be possible, using `DeclarationOrder` https://checkstyle.sourceforge.io/config_coding.html#DeclarationOrder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] github-actions[bot] commented on issue #7186: Enforce variable order in checkstyle
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #7186:
URL: https://github.com/apache/iceberg/issues/7186#issuecomment-1728579296
This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org