[jira] [Commented] (SQOOP-2598) Sqoop2: Main sqoop.log is missing log outputs from classes other then org.apache.sqoop

["Sqoop QA bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-2598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941320#comment-14941320 ] 

Sqoop QA bot commented on SQOOP-2598:
-------------------------------------

Testing file [SQOOP-2598.patch|https://issues.apache.org/jira/secure/attachment/12764709/SQOOP-2598.patch] against branch sqoop2 took 0:54:30.221531.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1434 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1744/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1744/artifact/patch-process/findbugs_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 89 tests)

Console output is available [here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1744/console].

This message is automatically generated.

> Sqoop2: Main sqoop.log is missing log outputs from classes other then org.apache.sqoop
> --------------------------------------------------------------------------------------
>
>                 Key: SQOOP-2598
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2598
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.99.6
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.7
>
>         Attachments: SQOOP-2598.patch
>
>
> While working with [~abrahamfine] on failing integration tests on our laptops we've noticed that the main Sqoop server log {{sqoop.log}} contains log lines only from classes inside {{org.apache.sqoop}} namespace but is missing logs from any other classes - in particular I was missing logs from {{org.apache.hadoop}}. 
> I've spent some time investigating the issue and found out that we're currently configuring log4j twice. Once in {{[SqoopConfiguration|https://github.com/apache/sqoop/blob/sqoop2/core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java#L283]}} for entire server, but then for second time in the {{[FileAuditLogger|https://github.com/apache/sqoop/blob/sqoop2/core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java#L63]}} for audit logger. Those two configurations are however messing with each other resulting in the described behavior.
> I would like to propose refactoring the {{FileAuditLogger}} to be a bit smarter and rather then reconfiguring the log4j, only use *already* defined logger. This way user still have ability to specify arbitrary number of instances that can be configured to log to different files and we would have to configure log4j only once.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)