You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/16 01:39:25 UTC

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1049: feat: support patch in route module in order to support publish/offline

nic-chen commented on pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#issuecomment-745707428


   > It seems that the E2E test cases is unstable, @nic-chen please take a look:
   > 
   > ```
   > --- FAIL: TestRoute_Create_Service (0.93s)
   > Error:     printer.go:54: GET http://127.0.0.1:9080/server_port
   > Error:     printer.go:54: PUT http://127.0.0.1:9000/apisix/admin/services/200
   > Error:     printer.go:54: PUT http://127.0.0.1:9000/apisix/admin/routes/r1
   >     route_service_upstream_test.go:190: 
   >         	Error Trace:	route_service_upstream_test.go:190
   >         	Error:      	Not equal: 
   >         	            	expected: 6
   >         	            	actual  : 7
   >         	Test:       	TestRoute_Create_Service
   >     route_service_upstream_test.go:192: 
   >         	Error Trace:	route_service_upstream_test.go:192
   >         	Error:      	Not equal: 
   >         	            	expected: 6
   >         	            	actual  : 5
   >         	Test:       	TestRoute_Create_Service
   > ```
   
   en, I have been working on it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org