[GitHub] asdf2014 commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory`

[GitBox <gi...@apache.org>]

asdf2014 commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory`
URL: https://github.com/apache/incubator-druid/pull/6090#issuecomment-410119637
 
 
   Hi, @jihoonson . Yep, that's right. :+1: Perhaps something in this PR is still useful, for example, use `channel.isOpen()` to check that the channel is open before call `channel.close()` method and use `ExpectedException` instead of `Assert.assertTrue`. Do you want to close this, or change the title and keep those useful changes? :sweat_smile:

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org