You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2011/02/18 08:57:11 UTC

[jira] Created: (FELIX-2849) PackageAdmin is inconsistent between getFragments and getHosts

PackageAdmin is inconsistent between getFragments and getHosts
--------------------------------------------------------------

                 Key: FELIX-2849
                 URL: https://issues.apache.org/jira/browse/FELIX-2849
             Project: Felix
          Issue Type: Bug
            Reporter: Guillaume Nodet


getFragments returns a list of fragments attached to the current module, while getHosts returns a list of all dependant bundles (not only hosts) for all revisions of the bundle.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (FELIX-2849) PackageAdmin is inconsistent between getFragments and getHosts

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996454#comment-12996454 ] 

Richard S. Hall commented on FELIX-2849:
----------------------------------------

For dependencies, I always return from all revisions, because these are the actual dependencies. See getImportingBundles(), for example, it is done the same way, it returns anyone importing from any revision of the bundle. Looking at getFragments(), it is the one that should probably be changed to work like the others.

> PackageAdmin is inconsistent between getFragments and getHosts
> --------------------------------------------------------------
>
>                 Key: FELIX-2849
>                 URL: https://issues.apache.org/jira/browse/FELIX-2849
>             Project: Felix
>          Issue Type: Bug
>            Reporter: Guillaume Nodet
>
> getFragments returns a list of fragments attached to the current module, while getHosts returns a list of all dependant bundles (not only hosts) for all revisions of the bundle.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (FELIX-2849) PackageAdmin is inconsistent between getFragments and getHosts

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet reassigned FELIX-2849:
--------------------------------------

    Assignee: Guillaume Nodet

> PackageAdmin is inconsistent between getFragments and getHosts
> --------------------------------------------------------------
>
>                 Key: FELIX-2849
>                 URL: https://issues.apache.org/jira/browse/FELIX-2849
>             Project: Felix
>          Issue Type: Bug
>            Reporter: Guillaume Nodet
>            Assignee: Guillaume Nodet
>
> getFragments returns a list of fragments attached to the current module, while getHosts returns a list of all dependant bundles (not only hosts) for all revisions of the bundle.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (FELIX-2849) PackageAdmin is inconsistent between getFragments and getHosts

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996460#comment-12996460 ] 

Guillaume Nodet commented on FELIX-2849:
----------------------------------------

Sounds good, I'll write a patch for getFragments() then.

> PackageAdmin is inconsistent between getFragments and getHosts
> --------------------------------------------------------------
>
>                 Key: FELIX-2849
>                 URL: https://issues.apache.org/jira/browse/FELIX-2849
>             Project: Felix
>          Issue Type: Bug
>            Reporter: Guillaume Nodet
>
> getFragments returns a list of fragments attached to the current module, while getHosts returns a list of all dependant bundles (not only hosts) for all revisions of the bundle.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (FELIX-2849) PackageAdmin is inconsistent between getFragments and getHosts

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996438#comment-12996438 ] 

Richard S. Hall commented on FELIX-2849:
----------------------------------------

Fragments can only have one type of dependency, which is the host they are attached to, so it seems returning all dependents of the fragment for getHosts() is correct, unless I am missing something.

> PackageAdmin is inconsistent between getFragments and getHosts
> --------------------------------------------------------------
>
>                 Key: FELIX-2849
>                 URL: https://issues.apache.org/jira/browse/FELIX-2849
>             Project: Felix
>          Issue Type: Bug
>            Reporter: Guillaume Nodet
>
> getFragments returns a list of fragments attached to the current module, while getHosts returns a list of all dependant bundles (not only hosts) for all revisions of the bundle.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (FELIX-2849) PackageAdmin is inconsistent between getFragments and getHosts

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996449#comment-12996449 ] 

Guillaume Nodet commented on FELIX-2849:
----------------------------------------

Well, that still leaves the problem that it returns hosts for all revisions, so in my case, I can either have a host when the fragment is unresolved (for an older revision) or even a list with multiple bundles (one host for each revision).  I think only the last revision should be checked so that the result is consistent between getFramgments and getHosts.

> PackageAdmin is inconsistent between getFragments and getHosts
> --------------------------------------------------------------
>
>                 Key: FELIX-2849
>                 URL: https://issues.apache.org/jira/browse/FELIX-2849
>             Project: Felix
>          Issue Type: Bug
>            Reporter: Guillaume Nodet
>
> getFragments returns a list of fragments attached to the current module, while getHosts returns a list of all dependant bundles (not only hosts) for all revisions of the bundle.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (FELIX-2849) PackageAdmin is inconsistent between getFragments and getHosts

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996449#comment-12996449 ] 

Guillaume Nodet edited comment on FELIX-2849 at 2/18/11 3:21 PM:
-----------------------------------------------------------------

Well, that still leaves the problem that it returns hosts for all revisions, so in my case, I can either have a host when the fragment is unresolved (for an older revision) or even a list with multiple bundles (one host for each revision).  I think only the last revision should be checked so that the result is consistent between getFragments and getHosts.

      was (Author: gnt):
    Well, that still leaves the problem that it returns hosts for all revisions, so in my case, I can either have a host when the fragment is unresolved (for an older revision) or even a list with multiple bundles (one host for each revision).  I think only the last revision should be checked so that the result is consistent between getFramgments and getHosts.
  
> PackageAdmin is inconsistent between getFragments and getHosts
> --------------------------------------------------------------
>
>                 Key: FELIX-2849
>                 URL: https://issues.apache.org/jira/browse/FELIX-2849
>             Project: Felix
>          Issue Type: Bug
>            Reporter: Guillaume Nodet
>
> getFragments returns a list of fragments attached to the current module, while getHosts returns a list of all dependant bundles (not only hosts) for all revisions of the bundle.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (FELIX-2849) PackageAdmin is inconsistent between getFragments and getHosts

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996464#comment-12996464 ] 

Richard S. Hall commented on FELIX-2849:
----------------------------------------

Ok.

This sort of issue is precisely why a BundleRevision concept was included in the new R4.3 API so that you could accurately model these sorts of relationships which up until now had to be flattened into the Bundle level. I plan to start working on the R4.3 API after I get the resolver in shape, so pretty soon you'll have that at your disposal.

> PackageAdmin is inconsistent between getFragments and getHosts
> --------------------------------------------------------------
>
>                 Key: FELIX-2849
>                 URL: https://issues.apache.org/jira/browse/FELIX-2849
>             Project: Felix
>          Issue Type: Bug
>            Reporter: Guillaume Nodet
>
> getFragments returns a list of fragments attached to the current module, while getHosts returns a list of all dependant bundles (not only hosts) for all revisions of the bundle.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (FELIX-2849) PackageAdmin is inconsistent between getFragments and getHosts

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet resolved FELIX-2849.
------------------------------------

       Resolution: Fixed
    Fix Version/s: framework-3.0.9

> PackageAdmin is inconsistent between getFragments and getHosts
> --------------------------------------------------------------
>
>                 Key: FELIX-2849
>                 URL: https://issues.apache.org/jira/browse/FELIX-2849
>             Project: Felix
>          Issue Type: Bug
>            Reporter: Guillaume Nodet
>            Assignee: Guillaume Nodet
>             Fix For: framework-3.0.9
>
>
> getFragments returns a list of fragments attached to the current module, while getHosts returns a list of all dependant bundles (not only hosts) for all revisions of the bundle.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira