You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2014/06/16 16:11:18 UTC
svn commit: r1602871 - /subversion/trunk/subversion/libsvn_fs/fs-loader.c
Author: stsp
Date: Mon Jun 16 14:11:17 2014
New Revision: 1602871
URL: http://svn.apache.org/r1602871
Log:
* subversion/libsvn_fs/fs-loader.c
(svn_fs_commit_txn): Remove #ifdef PACK_AFTER_EVERY_COMMIT. It has been
redundant since r1577362 which added a run-time configuration option
to fsfs.conf to toggle the same behaviour.
Modified:
subversion/trunk/subversion/libsvn_fs/fs-loader.c
Modified: subversion/trunk/subversion/libsvn_fs/fs-loader.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs/fs-loader.c?rev=1602871&r1=1602870&r2=1602871&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs/fs-loader.c (original)
+++ subversion/trunk/subversion/libsvn_fs/fs-loader.c Mon Jun 16 14:11:17 2014
@@ -864,20 +864,6 @@ svn_fs_commit_txn(const char **conflict_
SVN_ERR(err);
-#ifdef PACK_AFTER_EVERY_COMMIT
- {
- svn_fs_t *fs = txn->fs;
- const char *fs_path = svn_fs_path(fs, pool);
- err = svn_fs_pack(fs_path, NULL, NULL, NULL, NULL, pool);
- if (err && err->apr_err == SVN_ERR_UNSUPPORTED_FEATURE)
- /* Pre-1.6 filesystem. */
- svn_error_clear(err);
- else if (err)
- /* Real error. */
- return svn_error_trace(err);
- }
-#endif
-
return SVN_NO_ERROR;
}
Re: svn commit: r1602871 -
/subversion/trunk/subversion/libsvn_fs/fs-loader.c
Posted by Stefan Sperling <st...@elego.de>.
On Tue, Jun 17, 2014 at 12:08:05AM +0000, Daniel Shahaf wrote:
> stsp@apache.org wrote on Mon, Jun 16, 2014 at 14:11:18 -0000:
> > -#ifdef PACK_AFTER_EVERY_COMMIT
>
> Should we make it an #error for PACK_AFTER_EVERY_COMMIT to be defined?
> (in order to forcibly break any scripts that use the #define and expect it
> to have an effect)
>
> Daniel
I don't think many people have used this.
Are you aware of anyone other than yourself using this?
If you want this for your own builds, wouldn't adding this #error
definition to subversion/svn_private_config.h after running configure
do the trick?
./configure
printf '#ifdef PACK_AFTER_EVERY_COMMIT\n#error "PACK_AFTER_EVERY_COMMIT is defined"\n#endif\n' >> subversion/svn_private_config.h
make
Re: svn commit: r1602871 -
/subversion/trunk/subversion/libsvn_fs/fs-loader.c
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
stsp@apache.org wrote on Mon, Jun 16, 2014 at 14:11:18 -0000:
> -#ifdef PACK_AFTER_EVERY_COMMIT
Should we make it an #error for PACK_AFTER_EVERY_COMMIT to be defined?
(in order to forcibly break any scripts that use the #define and expect it
to have an effect)
Daniel