Re: Package Access Issues / Extending FacetComponent

[wojtekpia <wo...@hotmail.com>]

I've created SOLR-748 for this issue and attached a patch:

https://issues.apache.org/jira/browse/SOLR-748



wojtekpia wrote:
> 
> Thanks, I'll do that. I'll wait until 1.3 has been released to submit a
> patch. (This will be my first one, so bear with me!)
> 
> 
> hossman wrote:
>> 
>> 
>> : 1. Copy all those classes into my own package, copy the FacetComponent
>> into
>> : my own package, and then override as I intended (there might still be
>> some
>> : issues with accessing ResponseBuilder._facetInfo). 
>> : 2. Re-write the entire component using only the ShardResponse. 
>> : 3. Make those classes publicly accessible.
>> 
>> short term 1&2 are your best bets ... long term submit a patch that 
>> makes things public/protected as you think are warranted.  We'll use the 
>> Jira issue to discuss wether those are APIs that we want to really expose 
>> to plugin developers, or if we want to refactor the APIs to clean them
>> up.
>> 
>> (many things tend to be private or package-protected initally to protect 
>> against people using half baked APIs ... it's discussions like this theat 
>> help shake them out and make them more robust and usable)
>> 
>> 
>> 
>> -Hoss
>> 
>> 
>> 
> 
> 

-- 
View this message in context: http://www.nabble.com/Package-Access-Issues---Extending-FacetComponent-tp19148122p19280476.html
Sent from the Solr - Dev mailing list archive at Nabble.com.