[GitHub] [beam] lukecwik commented on pull request #13069: [BEAM-10475] Add a well-known coder for ShardedKey in Java SDK

[GitBox <gi...@apache.org>]

lukecwik commented on pull request #13069:
URL: https://github.com/apache/beam/pull/13069#issuecomment-707242853


   > R: @robertwb @lukecwik
   > 
   > PTAL and see if the changes make sense and if there is anything I am missing.
   > 
   > I am not sure what to do with the .yaml files... The locally modified file `sdks/python/apache_beam/portability/api/standard_coders.yaml` caused some python tests fail somehow. I wasn't intended to include that file in this PR since it is for Java SDk but I ended up reverting the changes and added that file here. Any guidance?
   
   I don't think you should be creating a copy of standard_coders.yaml inside the python sdk. I was under the impression that the build process somehow moved the single standard_coders.yaml file around and made it available to the Python test but that might only be occurring during import into google.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org