[GitHub] [submarine] noidname01 commented on a change in pull request #767: SUBMARINE-1021. Experiment Watcher

[GitBox <gi...@apache.org>]

noidname01 commented on a change in pull request #767:
URL: https://github.com/apache/submarine/pull/767#discussion_r725608709



##########
File path: submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sSubmitter.java
##########
@@ -133,7 +146,13 @@ public void initialize(SubmarineConfiguration conf) {
       appsV1Api = new AppsV1Api();
     }
 
-    client.setDebugging(true);
+    try {
+      watchExperiment();
+    } catch (Exception e){
+      LOG.error("Experiment watch failed. " + e.getMessage(), e);
+    }
+
+    // client.setDebugging(true);

Review comment:
       I commented this line is because Watch in Java k8s client library seems not to support debugging mode, it made the watcher failed.
   
   I'll just remove it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org