You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by dp...@apache.org on 2020/10/02 08:12:31 UTC
[incubator-superset] branch master updated: fix: Alembic migration
18532d70ab98 (#11136)
This is an automated email from the ASF dual-hosted git repository.
dpgaspar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new e90c63f fix: Alembic migration 18532d70ab98 (#11136)
e90c63f is described below
commit e90c63fc7b911efc16919abf5b017aa0f6250985
Author: John Bodley <45...@users.noreply.github.com>
AuthorDate: Fri Oct 2 01:12:03 2020 -0700
fix: Alembic migration 18532d70ab98 (#11136)
---
.../18532d70ab98_fix_table_unique_constraint_in_mysql.py | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/superset/migrations/versions/18532d70ab98_fix_table_unique_constraint_in_mysql.py b/superset/migrations/versions/18532d70ab98_fix_table_unique_constraint_in_mysql.py
index c011c06..79aef84 100644
--- a/superset/migrations/versions/18532d70ab98_fix_table_unique_constraint_in_mysql.py
+++ b/superset/migrations/versions/18532d70ab98_fix_table_unique_constraint_in_mysql.py
@@ -28,14 +28,22 @@ down_revision = "3fbbc6e8d654"
from alembic import op
from sqlalchemy.dialects.mysql.base import MySQLDialect
+from sqlalchemy.engine.reflection import Inspector
+
+from superset.utils.core import generic_find_uq_constraint_name
def upgrade():
bind = op.get_bind()
+
+ # Uniqueness constraint if present only exists in MySQL.
if isinstance(bind.dialect, MySQLDialect):
- # index only exists in mysql db
- with op.get_context().autocommit_block():
- op.drop_constraint("table_name", "tables", type_="unique")
+ constraint_name = generic_find_uq_constraint_name(
+ "tables", {"table_name"}, Inspector.from_engine(bind)
+ )
+
+ if constraint_name:
+ op.drop_constraint(constraint_name, "tables", type_="unique")
def downgrade():