You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2020/04/07 23:44:22 UTC
[kudu-CR] columnar serialization: fix build on older gccs
Hello Adar Dembo, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15680
to review the following change.
Change subject: columnar_serialization: fix build on older gccs
......................................................................
columnar_serialization: fix build on older gccs
It seems that GCC expects particular pointer types for the first
argument to the _mm_gather* intrinsics. This adds the appropriate type
casts. I wasn't able to reproduce the build error on my Ubuntu 18
system, but was able to reproduce it on godbolt.
Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7
---
M src/kudu/common/columnar_serialization.cc
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/15680/1
--
To view, visit http://gerrit.cloudera.org:8080/15680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7
Gerrit-Change-Number: 15680
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] columnar serialization: fix optimized GCC build
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15680 )
Change subject: columnar_serialization: fix optimized GCC build
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15680/2/src/kudu/common/columnar_serialization.cc
File src/kudu/common/columnar_serialization.cc:
http://gerrit.cloudera.org:8080/#/c/15680/2/src/kudu/common/columnar_serialization.cc@389
PS2, Line 389: long long int
> Why not int64_t? Could you add a comment?
Since this is breaking some builds I will merge and leave that comment and potential minor adjustment for a follow up.
--
To view, visit http://gerrit.cloudera.org:8080/15680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7
Gerrit-Change-Number: 15680
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 08 Apr 2020 00:43:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] columnar serialization: fix optimized GCC build
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15680 )
Change subject: columnar_serialization: fix optimized GCC build
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15680/2/src/kudu/common/columnar_serialization.cc
File src/kudu/common/columnar_serialization.cc:
http://gerrit.cloudera.org:8080/#/c/15680/2/src/kudu/common/columnar_serialization.cc@389
PS2, Line 389: long long int
Why not int64_t? Could you add a comment?
--
To view, visit http://gerrit.cloudera.org:8080/15680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7
Gerrit-Change-Number: 15680
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 08 Apr 2020 00:04:45 +0000
Gerrit-HasComments: Yes
[kudu-CR] columnar serialization: fix build on older gccs
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15680 )
Change subject: columnar_serialization: fix build on older gccs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7
Gerrit-Change-Number: 15680
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 07 Apr 2020 23:50:48 +0000
Gerrit-HasComments: No
[kudu-CR] columnar serialization: fix optimized GCC build
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15680 )
Change subject: columnar_serialization: fix optimized GCC build
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15680/2/src/kudu/common/columnar_serialization.cc
File src/kudu/common/columnar_serialization.cc:
http://gerrit.cloudera.org:8080/#/c/15680/2/src/kudu/common/columnar_serialization.cc@389
PS2, Line 389: long long int
> Since this is breaking some builds I will merge and leave that comment and
SGTM
I was just curious whether it will break macOS build because of that. But it seems it's all right now, if I'm not mistaken.
--
To view, visit http://gerrit.cloudera.org:8080/15680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7
Gerrit-Change-Number: 15680
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 08 Apr 2020 20:51:39 +0000
Gerrit-HasComments: Yes
[kudu-CR] columnar serialization: fix optimized GCC build
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15680 )
Change subject: columnar_serialization: fix optimized GCC build
......................................................................
columnar_serialization: fix optimized GCC build
It seems that GCC with -O1 or higher is less lenient about the pointer
types passed as the first argument to the _mm_gather* intrinsics. This
was causing the Ubuntu 18 release build to fail.
I was able to reproduce the failure and fix on my own Ubuntu 18 box
using a fastdebug build.
Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7
Reviewed-on: http://gerrit.cloudera.org:8080/15680
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/common/columnar_serialization.cc
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7
Gerrit-Change-Number: 15680
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] columnar serialization: fix optimized GCC build
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15680
to look at the new patch set (#2).
Change subject: columnar_serialization: fix optimized GCC build
......................................................................
columnar_serialization: fix optimized GCC build
It seems that GCC with -O1 or higher is less lenient about the pointer
types passed as the first argument to the _mm_gather* intrinsics. This
was causing the Ubuntu 18 release build to fail.
I was able to reproduce the failure and fix on my own Ubuntu 18 box
using a fastdebug build.
Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7
---
M src/kudu/common/columnar_serialization.cc
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/15680/2
--
To view, visit http://gerrit.cloudera.org:8080/15680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7
Gerrit-Change-Number: 15680
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)