You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2016/12/09 23:38:36 UTC

Re: Review Request 52461: Ported apply-reviews.py script to Windows.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52461/#review158729
-----------------------------------------------------------



I like this, but in the same vein we are still calling `git` the CLI manually, which is error prone. We might want to switch to `GitPython` or `pygit2` at some point.

- Andrew Schwartzmeyer


On Oct. 3, 2016, 6:09 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52461/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2016, 6:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This removes some of the shell-specific things this script was doing
> in favor of native Python, which works on Windows.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py 8dc1817943d7681b90d64c10bcd82acd7b7cef9d 
> 
> Diff: https://reviews.apache.org/r/52461/diff/
> 
> 
> Testing
> -------
> 
> On Windows and OSX:
> python support/apply-reviews.py -n -r <#####>
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>